Skip to content

Commit

Permalink
[Security Solution] Re-adds a test that was skipped (elastic#100273)
Browse files Browse the repository at this point in the history
## Summary

Re-adds a test that was skipped. If it goes bonkers again, I will add more debugging information to it. I will keep an eye on the operations channel to see when/if this fails again. Originally this looked to be timeouts waiting, so I increased the global timeout to be 20 seconds instead of the original 10 seconds.

Resolves:
elastic#89389

### Checklist

- [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
  • Loading branch information
FrankHassanabad authored and yctercero committed May 25, 2021
1 parent a42bd37 commit 2f41a37
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -626,8 +626,7 @@ export default ({ getService }: FtrProviderContext) => {
expect(ips).to.eql(['127.0.0.1', '127.0.0.3']);
});

// flaky https://github.com/elastic/kibana/issues/89389
it.skip('will return 4 results if we have a list that excludes all ips', async () => {
it('will return 4 results if we have a list that excludes all ips', async () => {
await importFile(
supertest,
'ip',
Expand Down
2 changes: 1 addition & 1 deletion x-pack/test/detection_engine_api_integration/utils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -721,7 +721,7 @@ export const getSimpleRuleOutputWithWebHookAction = (actionId: string): Partial<
export const waitFor = async (
functionToTest: () => Promise<boolean>,
functionName: string,
maxTimeout: number = 10000,
maxTimeout: number = 20000,
timeoutWait: number = 10
): Promise<void> => {
await new Promise<void>(async (resolve, reject) => {
Expand Down

0 comments on commit 2f41a37

Please sign in to comment.