Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue where electron doesn't open with electron:dev task #48

Merged
merged 1 commit into from
Oct 13, 2022
Merged

Fix issue where electron doesn't open with electron:dev task #48

merged 1 commit into from
Oct 13, 2022

Commits on Oct 13, 2022

  1. fix issue where electron doesn't open with electron:dev task 

    "react-scripts start" launches a dev server on IPv4.
With Node 17+ on Windows, "wait-on http://localhost:3000" tries to connect over IPv6 and fails.
By changing the command to "wait-on http://127.0.0.1:3000", wait-on will make an IPv4 request and succeed, allowing electron to open.

Here's a related thread about other people running into this issue: jeffbski/wait-on#109
    @Macil
    Macil committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    b1fe4d0 View commit details
    Browse the repository at this point in the history