Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sections and href #36

Merged
merged 5 commits into from
Apr 3, 2024
Merged

Fix sections and href #36

merged 5 commits into from
Apr 3, 2024

Conversation

joshuaulrich
Copy link
Collaborator

This processes all sections and adds \href to the list of multi-argument macros.

@joshuaulrich
Add test Rd file
89e828b
@joshuaulrich
Process all sections
964a8bb 
Only the first section was being processed. Any later sections were
dropped silently.

Fixes yihui#25.
@joshuaulrich
Fix \href{}{}
ea5c07e 
Fixes yihui#22.
@joshuaulrich
Add \dots and \ldots to single argument macros
5aabaf5
yihui
yihui approved these changes Mar 21, 2024
View reviewed changes
Copy link
Owner

@yihui yihui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I just added you to this repo and you can merge this and future PRs by yourself if you want (don't forget to add a NEWS item).

@joshuaulrich joshuaulrich merged commit e23f740 into yihui:main Apr 3, 2024
5 checks passed
@joshuaulrich joshuaulrich deleted the fix-sections-and-href branch April 3, 2024 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yihui yihui yihui approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joshuaulrich @yihui