Refactor file name handling and sequence padding logic. #26
+19
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jakubjezek001
commented
Sep 26, 2024
jakubjezek001
commented
- Extracted file name from basename for processing.
- Improved handling of sequence padding using regex pattern matching.
- Enhanced file filtering based on the extracted file name.
- Extracted file name from basename for processing. - Improved handling of sequence padding using regex pattern matching. - Enhanced file filtering based on the extracted file name.
BigRoy
reviewed
Sep 26, 2024
- Refactored variable names for improved readability - Updated logic to handle file name patterns consistently
BigRoy
reviewed
Sep 26, 2024
| basename = basename.replace("#" * padding, seq_padding) | ||
| file_head = basename.split(seq_padding)[0] | ||
| is_sequence = True | ||
| if "%" in basename: |
There was a problem hiding this comment.
Should this be elif? Because after the first if the % will be in the basename and will then ALSO trigger that logic. Not sure if intentional?
There was a problem hiding this comment.
Agree this will run if the filename had # in filename, which is not needed, or?
iLLiCiTiT
reviewed
Sep 26, 2024
Comment on lines
+679
to
+680
| file for file in os.listdir(dirname) | ||
| if file_head in file |
There was a problem hiding this comment.
Suggested change
| file for file in os.listdir(dirname) | |
| if file_head in file | |
| filename | |
| for filename in os.listdir(dirname) | |
| if filename.startswith(file_head) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.