Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

generateTags: Add a null check to warn instead of throwing #207

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

generateTags: Add a null check to warn instead of throwing #207

wants to merge 1 commit into from

Conversation

jdanbrown
Copy link

  • This kept triggering in dev so I added a guard to warn and ignore
  • Not sure the root cause -- it could just be a spurious behavior from using atom-hot-package-loader, in which case it's just a harmless guard

@jdanbrown
generateTags: Add a null check to warn instead of throwing
e49ee93 
- This kept triggering in dev so I added a guard to warn and ignore
- Not sure the root cause -- it could just be a spurious behavior from using atom-hot-package-loader, in which case it's just a harmless guard
@jdanbrown jdanbrown mentioned this pull request Apr 25, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jdanbrown