Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reviewed: 1249-fix-csv-activity-import-function-data-type #1250

Merged
merged 1 commit into from
Jun 28, 2023
Merged

Reviewed: 1249-fix-csv-activity-import-function-data-type #1250

merged 1 commit into from
Jun 28, 2023

Conversation

A4family
Copy link
Collaborator

No description provided.

@A4family A4family requested a review from sriza June 28, 2023 11:35
@A4family A4family self-assigned this Jun 28, 2023
@what-the-diff
Copy link

what-the-diff bot commented Jun 28, 2023

PR Summary

  • Updated Return Type for autoFillSettingsValue Method
    The method for automatically setting up certain settings in activities has been updated. It's been reconfigured to return either a numeral, a character string, or nothing, instead of just a bunch of data or nothing. This change improves the precision and expected outcomes for this operation.

@sriza sriza changed the title Review: 1249-fix-csv-activity-import-function-data-type Reviewed: 1249-fix-csv-activity-import-function-data-type Jun 28, 2023
@A4family A4family force-pushed the 1249-fix-csv-activity-import-function-data-type branch from 5e8ba21 to d137d07 Compare June 28, 2023 11:42
@sriza sriza merged commit a91ea5e into main Jun 28, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sriza sriza sriza approved these changes

Assignees

@A4family A4family

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@A4family @sriza