Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review: 1492-remove-requirement-for-actual-and-target-value-against-a-result-period #1508

Conversation

PG-Momik
Copy link
Collaborator

No description provided.

Copy link

what-the-diff bot commented Jul 29, 2024

PR Summary

  • Established New Validation Rule
    A new rule has been added in the system that is responsible for the acceptance criteria of specific data input. This rule is located in PeriodRequest.php, and it requires either a target value or an actual value to be filled out by the user, meaning we won't accept incomplete data anymore. This will enforce better data integrity in our system. The implementation of this rule is included in a new file named RequiredEitherNumericTargetValueOrActualValue.php.

  • Style Modifications for Input Fields
    Updates have been made to the style resource file _input.scss. These modifications will alter the visual aspect of input fields in the user interface, bringing an improved and more user-friendly look and feel.

@Sanilblank Sanilblank merged commit 47870f8 into main Jul 30, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove requirement for "actual" and "target" value against a result period
2 participants