Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review: recover-email-changes #1516

Merged
merged 1 commit into from
Aug 1, 2024
Merged

Review: recover-email-changes #1516

merged 1 commit into from
Aug 1, 2024

Conversation

PG-Momik
Copy link
Collaborator

@PG-Momik PG-Momik commented Aug 1, 2024

  • Recover email changes

Copy link

what-the-diff bot commented Aug 1, 2024

PR Summary

  • Introduction of Negligible File Change Tracking
    To reduce clutter in our code versions and focus on important changes, files located in /public/css and /public/js are now ignored by Git.

  • Enhanced Password Reset Process
    By integrating User model in the ResetPasswordController, and introducing email verification logic in the resetPassword method, the password reset process is improved for better security and less potential errors.

  • Improvement in User Search
    Users can now be found in a case-insensitive manner in the user repository, thanks to the addition of orWhere('email', 'ilike', '%' . Arr::get($queryParams, 'q') . '%') to the filterUsers method, an enhancement that provides easier search capability.

  • Database Adaptation for Case-Insensitive Emails
    A migration file called 2024_07_22_091222_update_email_collation_in_users_table.php has been created that updates the database schema to support case-insensitive email addresses, offering more flexibility and user-friendliness.

  • Addition of Robust Testing for Enhanced Reliability
    A new test method test_successful_login_with_different_email_case in AuthenticationTest.php file ensures that our login process works effectively even when differing email cases are used, strengthening our system's robustness.

@A4family A4family merged commit d87ed9e into main Aug 1, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants