Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tracker: ab180 #272

Merged
merged 1 commit into from
Aug 6, 2023
Merged

tracker: ab180 #272

merged 1 commit into from
Aug 6, 2023

Conversation

seia-soto
Copy link
Contributor

Review required

A mitigation for Airbridge product; specially in deep-linking web to app integration and data collection.

Live sample:

  • https://www.sirloin.co.kr/

URL schemas:

core.airbridge.io/api/$version/apps/$appDirectory/$eventId
sdk.airbridge.io/data/$version/$appDirectory
  • $version is the integration version between the data api and SDK
  • $appDirectory is namespace identifier of AirBridge customer consisted of commonly used characters in HTTP URL; commonly viewed as application name (e.g. my-application)

I suggest adding $xhr and $3p if possible. However, I'm not sure about the status of sugar syntax support in YousList since the use of sugar syntax is literally low. In current version, I removed all sugars.

Checks

  1. General reproducability
  2. Syntax consideration

@piquark6046
Copy link
Contributor

Did you mean AdguardTeam/AdguardFilters#129318?

@yous
Copy link
Owner

yous commented Aug 4, 2023

It seems they're using https://static.airbridge.io/sdk/latest/airbridge.min.js, is it okay to block it? If I block it then core.airbirdge.io and sdk.airbridge.io requests are gone.

@seia-soto
Copy link
Contributor Author

Did you mean AdguardTeam/AdguardFilters#129318?

Your previous contribution to adguard filters actually does the same thing compared to this.

@seia-soto
Copy link
Contributor Author

It seems they're using https://static.airbridge.io/sdk/latest/airbridge.min.js, is it okay to block it? If I block it then core.airbirdge.io and sdk.airbridge.io requests are gone.

Your suggestion resolves my concern on possible site breakages by blocking at domain level. Additionally, I confirmed the resource is not used on internal dashboard via business account including personal one.

@yous
Copy link
Owner

yous commented Aug 6, 2023

I rebased your branch with ||static.airbridge.io/sdk/latest/airbridge.min.js^. Please have a check then I'll merge this.

@seia-soto
Copy link
Contributor Author

I confirmed your changes.

@yous yous merged commit 7b0eab3 into yous:master Aug 6, 2023
5 checks passed
@yous
Copy link
Owner

yous commented Aug 6, 2023

Thanks!

@piquark6046
Copy link
Contributor

#272 (comment)

Why? The topic of the contribution to AdguardFilters and this PR is same.
Did you mean that there is a difference at blocking level?

@seia-soto
Copy link
Contributor Author

seia-soto commented Aug 7, 2023

#272 (comment)

Why? The topic of the contribution to AdguardFilters and this PR is same. Did you mean that there is a difference at blocking level?

I don't understand what's your purpose to say like that. I mean the final outcome made by both two of them are same.

@seia-soto seia-soto deleted the tracker-airbridge1 branch November 15, 2023 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants