Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

matcher text doesn't work for children structural elements #144

Open
yshavit opened this issue Jul 18, 2024 · 1 comment
Open

matcher text doesn't work for children structural elements #144

yshavit opened this issue Jul 18, 2024 · 1 comment
Labels
question Further information is requested

Comments

@yshavit
Copy link
Owner

yshavit commented Jul 18, 2024

e.g. > - foo should match any block quote that has the text - foo, which includes:

> - foo bar

But it doesn't -- I think because StringMatcher::matches_any doesn't render structural elements.

I think I actually did that on purpose, so that for inlined elements, the matcher works on the displayed text, not the markdown:

hello _world_

hello world

... would match against hello world.

But maybe that's not a good idea, or isn't sufficient.
@yshavit yshavit added the bug Something isn't working label Jul 18, 2024
yshavit added a commit that referenced this issue Jul 18, 2024
@yshavit
add block quote selector
6727c33 
- syntax:
  ```
  > matcher
  ```
- add integ tests (unit tests are #84)
- found a bug in matching (#144), so I added the ability to mark integ
  tests as ignored

This resolves #143.
@yshavit yshavit mentioned this issue Jul 18, 2024
Merged
yshavit added a commit that referenced this issue Jul 18, 2024
@yshavit
add block quote selector
f28f445 
- syntax:
  ```
  > matcher
  ```
- add integ tests (unit tests are #84)
- found a bug in matching (#144), so I added the ability to mark integ
tests as ignored
- add to readme; will add to docs once this gets merged

Intellij auto-formatted my markdown, yay. Whatever.

This resolves #143.
@yshavit yshavit added this to the 1.0 milestone Jul 24, 2024
@yshavit yshavit added question Further information is requested and removed bug Something isn't working labels Aug 11, 2024
@yshavit
Copy link
Owner Author

yshavit commented Aug 11, 2024 •
edited
Loading

Kicking this out of the 1.0-beta milestone, as I'm not sure what I even want to do in this case.

@yshavit yshavit removed this from the 1.0 milestone Aug 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@yshavit