Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Octree ray tracing #2442

Closed
wants to merge 88 commits into from
Closed

[WIP] Octree ray tracing #2442

wants to merge 88 commits into from

Commits on May 5, 2020

  1. Add support for fast neighbour search

    @cphyc
    cphyc committed May 5, 2020
    Configuration menu
    Copy the full SHA
    296dcc0 View commit details
    Browse the repository at this point in the history

  2. More generic code

    @cphyc
    cphyc committed May 5, 2020
    Configuration menu
    Copy the full SHA
    57f3dae View commit details
    Browse the repository at this point in the history

  3. Remove useless variable on oct container

    @cphyc
    cphyc committed May 5, 2020
    Configuration menu
    Copy the full SHA
    64c0712 View commit details
    Browse the repository at this point in the history

  4. First working (not crashing version)

    @cphyc
    cphyc committed May 5, 2020
    Configuration menu
    Copy the full SHA
    b622ce2 View commit details
    Browse the repository at this point in the history

  5. Does not work yet, but hey it compiles

    @cphyc
    cphyc committed May 5, 2020
    Configuration menu
    Copy the full SHA
    7022fe3 View commit details
    Browse the repository at this point in the history

  6. Wiring cython code with ghost zones

    @cphyc
    cphyc committed May 5, 2020
    Configuration menu
    Copy the full SHA
    5cf2d0e View commit details
    Browse the repository at this point in the history

  7. Cleanup

    @cphyc
    cphyc committed May 5, 2020
    Configuration menu
    Copy the full SHA
    34fb2bf View commit details
    Browse the repository at this point in the history

  8. First working (not crashing) version

    @cphyc
    cphyc committed May 5, 2020
    Configuration menu
    Copy the full SHA
    9c6a253 View commit details
    Browse the repository at this point in the history

  9. Fix octree accessor

    @cphyc
    cphyc committed May 5, 2020
    Configuration menu
    Copy the full SHA
    fed8f78 View commit details
    Browse the repository at this point in the history

  10. Forget about nan when doing gradients

    @cphyc
    cphyc committed May 5, 2020
    Configuration menu
    Copy the full SHA
    b622243 View commit details
    Browse the repository at this point in the history

  11. Accept unyt_array as center

    @cphyc
    cphyc committed May 5, 2020
    Configuration menu
    Copy the full SHA
    e496b25 View commit details
    Browse the repository at this point in the history

  12. Gradient should be block order-aware

    @cphyc
    cphyc committed May 5, 2020
    Configuration menu
    Copy the full SHA
    1010f70 View commit details
    Browse the repository at this point in the history

  13. cAdd comments

    @cphyc
    cphyc committed May 5, 2020
    Configuration menu
    Copy the full SHA
    1075d7b View commit details
    Browse the repository at this point in the history

  14. Support reading boundaries between CPUs

    @cphyc
    cphyc committed May 5, 2020
    Configuration menu
    Copy the full SHA
    d3005a6 View commit details
    Browse the repository at this point in the history

  15. Filling hydro with boundary information

    @cphyc
    cphyc committed May 5, 2020
    Configuration menu
    Copy the full SHA
    e72aa4c View commit details
    Browse the repository at this point in the history

  16. Use Fortran ordering to read in for faster results

    @cphyc
    cphyc committed May 5, 2020
    Configuration menu
    Copy the full SHA
    0f5ce50 View commit details
    Browse the repository at this point in the history

  17. Working version? 

    This is not crashing and there are very few glitches.
    @cphyc
    cphyc committed May 5, 2020
    Configuration menu
    Copy the full SHA
    37f30f6 View commit details
    Browse the repository at this point in the history

  18. Correct erroneous reference

    @cphyc
    cphyc committed May 5, 2020
    Configuration menu
    Copy the full SHA
    8bc864c View commit details
    Browse the repository at this point in the history

  19. Catch early bug

    @cphyc
    cphyc committed May 5, 2020
    Configuration menu
    Copy the full SHA
    779cd0c View commit details
    Browse the repository at this point in the history

  20. More explicit names

    @cphyc
    cphyc committed May 5, 2020
    Configuration menu
    Copy the full SHA
    c6aaf6b View commit details
    Browse the repository at this point in the history

  21. Correct discrepancy between .pxd and .pyx file

    @cphyc
    cphyc committed May 5, 2020
    Configuration menu
    Copy the full SHA
    b75ea7a View commit details
    Browse the repository at this point in the history

  22. UNSURE ABOUT THIS ONE, REMOVE ME IF YOU HAVE WEIRD RESULTS

    @cphyc
    cphyc committed May 5, 2020
    Configuration menu
    Copy the full SHA
    ae21846 View commit details
    Browse the repository at this point in the history

  23. Read boundary regions as well

    @cphyc
    cphyc committed May 5, 2020
    Configuration menu
    Copy the full SHA
    a65f9c6 View commit details
    Browse the repository at this point in the history

  24. Cannot assume that keys are string by default (can be tuple)

    @cphyc
    cphyc committed May 5, 2020
    Configuration menu
    Copy the full SHA
    d4c48ad View commit details
    Browse the repository at this point in the history

  25. Inform gradient about ordering

    @cphyc
    cphyc committed May 5, 2020
    Configuration menu
    Copy the full SHA
    e2ba516 View commit details
    Browse the repository at this point in the history

  26. Use less ambiguous name 

    ds usually refers to a dataset.
    @cphyc
    cphyc committed May 5, 2020
    Configuration menu
    Copy the full SHA
    536b06a View commit details
    Browse the repository at this point in the history

  27. Use block_reorder to decide when transposing

    @cphyc
    cphyc committed May 5, 2020
    Configuration menu
    Copy the full SHA
    f02e559 View commit details
    Browse the repository at this point in the history

  28. ("index, "ones") should return data with units

    @cphyc
    cphyc committed May 5, 2020
    Configuration menu
    Copy the full SHA
    6e3aa4c View commit details
    Browse the repository at this point in the history

  29. Add unit test

    @cphyc
    cphyc committed May 5, 2020
    Configuration menu
    Copy the full SHA
    b8e8765 View commit details
    Browse the repository at this point in the history

  30. Add new answer test

    @cphyc
    cphyc committed May 5, 2020
    Configuration menu
    Copy the full SHA
    0175f85 View commit details
    Browse the repository at this point in the history

  31. Move non-specific code into oct_container.pyx

    @cphyc
    cphyc committed May 5, 2020
    Configuration menu
    Copy the full SHA
    fb180ad View commit details
    Browse the repository at this point in the history

  32. Remove unused parent accessor

    @cphyc
    cphyc committed May 5, 2020
    Configuration menu
    Copy the full SHA
    aa28f1a View commit details
    Browse the repository at this point in the history

  33. RAMSES octree is sparse, restore this

    @cphyc
    cphyc committed May 5, 2020
    Configuration menu
    Copy the full SHA
    d2bad6d View commit details
    Browse the repository at this point in the history

  34. Update docstring

    @cphyc
    cphyc committed May 5, 2020
    Configuration menu
    Copy the full SHA
    13ffd02 View commit details
    Browse the repository at this point in the history

  35. Restore div_fac ability in gradient

    @cphyc
    cphyc committed May 5, 2020
    Configuration menu
    Copy the full SHA
    af78d6a View commit details
    Browse the repository at this point in the history

  36. Only query fcoords w/o ghost zones

    @cphyc
    cphyc committed May 5, 2020
    Configuration menu
    Copy the full SHA
    0d5db45 View commit details
    Browse the repository at this point in the history

  37. Assume periodicity

    @cphyc
    cphyc committed May 5, 2020
    Configuration menu
    Copy the full SHA
    47b1f3d View commit details
    Browse the repository at this point in the history

  38. Add warning

    @cphyc
    cphyc committed May 5, 2020
    Configuration menu
    Copy the full SHA
    cde3a1b View commit details
    Browse the repository at this point in the history

  39. Vastly simplify code

    @cphyc
    cphyc committed May 5, 2020
    Configuration menu
    Copy the full SHA
    beea31f View commit details
    Browse the repository at this point in the history

  40. Remove useless import

    @cphyc
    cphyc committed May 5, 2020
    Configuration menu
    Copy the full SHA
    c025a37 View commit details
    Browse the repository at this point in the history

  41. Remove unused visitor

    @cphyc
    cphyc committed May 5, 2020
    Configuration menu
    Copy the full SHA
    0752ed5 View commit details
    Browse the repository at this point in the history

  42. Remove useless method

    @cphyc
    cphyc committed May 5, 2020
    Configuration menu
    Copy the full SHA
    fd3f5ed View commit details
    Browse the repository at this point in the history

  43. Initial implementation 

    Ray traversal works for positive directions
    @cphyc
    cphyc committed May 5, 2020
    Configuration menu
    Copy the full SHA
    81fa0cd View commit details
    Browse the repository at this point in the history

  44. This should work for finding the root node

    @cphyc
    cphyc committed May 5, 2020
    Configuration menu
    Copy the full SHA
    597f85a View commit details
    Browse the repository at this point in the history

  45. Now works for non uniform grids

    @cphyc
    cphyc committed May 5, 2020
    Configuration menu
    Copy the full SHA
    88f33ed View commit details
    Browse the repository at this point in the history

  46. Add test

    @cphyc
    cphyc committed May 5, 2020
    Configuration menu
    Copy the full SHA
    6725089 View commit details
    Browse the repository at this point in the history

  47. Use C++ vectors instead of python lists

    @cphyc
    cphyc committed May 5, 2020
    Configuration menu
    Copy the full SHA
    0bf130b View commit details
    Browse the repository at this point in the history

  48. Revert to Revelles implementation 

    Note that this is *not* working yet
    @cphyc
    cphyc committed May 5, 2020
    Configuration menu
    Copy the full SHA
    6d1c4db View commit details
    Browse the repository at this point in the history

  49. Base work to also return t value

    @cphyc
    cphyc committed May 5, 2020
    Configuration menu
    Copy the full SHA
    66e6d47 View commit details
    Browse the repository at this point in the history

  50. Fix entry node

    @cphyc
    cphyc committed May 5, 2020
    Configuration menu
    Copy the full SHA
    5493f6e View commit details
    Browse the repository at this point in the history

  51. Also return t value 

    This returns the far t value for leaf cells
    @cphyc
    cphyc committed May 5, 2020
    Configuration menu
    Copy the full SHA
    32cc3f9 View commit details
    Browse the repository at this point in the history

  52. Return cell indices in Fortran order

    @cphyc
    cphyc committed May 5, 2020
    Configuration menu
    Copy the full SHA
    5c05da7 View commit details
    Browse the repository at this point in the history

  53. Return the right number of items when oct is null

    @cphyc
    cphyc committed May 5, 2020
    Configuration menu
    Copy the full SHA
    0f19a49 View commit details
    Browse the repository at this point in the history

  54. Update tests 

    Some weird results seem to happen...
    @cphyc
    cphyc committed May 5, 2020
    Configuration menu
    Copy the full SHA
    e9541ed View commit details
    Browse the repository at this point in the history

  55. Should now traverse entire domain

    @cphyc
    cphyc committed May 5, 2020
    Configuration menu
    Copy the full SHA
    82ae1b6 View commit details
    Browse the repository at this point in the history

  56. Now loops over root nodes

    @cphyc
    cphyc committed May 5, 2020
    Configuration menu
    Copy the full SHA
    58365e8 View commit details
    Browse the repository at this point in the history

  57. Also check exit of root node has positive t value

    @cphyc
    cphyc committed May 5, 2020
    Configuration menu
    Copy the full SHA
    acce05a View commit details
    Browse the repository at this point in the history

  58. Useful function to reconstruct indexes

    @cphyc
    cphyc committed May 5, 2020
    Configuration menu
    Copy the full SHA
    75ebf63 View commit details
    Browse the repository at this point in the history

  59. Machinery to support multiple domains

    @cphyc
    cphyc committed May 5, 2020
    Configuration menu
    Copy the full SHA
    6c99c5a View commit details
    Browse the repository at this point in the history

  60. Traversing multiple domains

    @cphyc
    cphyc committed May 5, 2020
    Configuration menu
    Copy the full SHA
    7bf3bea View commit details
    Browse the repository at this point in the history

  61. Prereserve data

    @cphyc
    cphyc committed May 5, 2020
    Configuration menu
    Copy the full SHA
    a02c778 View commit details
    Browse the repository at this point in the history

  62. Better handle domain-switching

    @cphyc
    cphyc committed May 5, 2020
    Configuration menu
    Copy the full SHA
    e99132c View commit details
    Browse the repository at this point in the history

  63. Assign right domain number to octs that span multiple domains

    @cphyc
    cphyc committed May 5, 2020
    Configuration menu
    Copy the full SHA
    9f9d2b0 View commit details
    Browse the repository at this point in the history

  64. This should now support multiple domains

    @cphyc
    cphyc committed May 5, 2020
    Configuration menu
    Copy the full SHA
    075d691 View commit details
    Browse the repository at this point in the history

  65. Make the hilbert lookup much faster 

    The cython code runs in about 4.34 µs ± 164 ns (for a single lookup).
The python code runs in about 187 µs ± 8.98 µs (for a single lookup),
i.e. 4x slower.
    @cphyc
    cphyc committed May 5, 2020
    Configuration menu
    Copy the full SHA
    aa5b4d5 View commit details
    Browse the repository at this point in the history

  66. Prepare ground for finding the entrance node

    @cphyc
    cphyc committed May 5, 2020
    Configuration menu
    Copy the full SHA
    ee6c0f2 View commit details
    Browse the repository at this point in the history

  67. Now locates the entrance domain

    @cphyc
    cphyc committed May 5, 2020
    Configuration menu
    Copy the full SHA
    9a87548 View commit details
    Browse the repository at this point in the history

  68. COmparison should be with a !+

    @cphyc
    cphyc committed May 5, 2020
    Configuration menu
    Copy the full SHA
    894cde6 View commit details
    Browse the repository at this point in the history

  69. Move constant stuff to pxd file

    @cphyc
    cphyc committed May 5, 2020
    Configuration menu
    Copy the full SHA
    ddfe49d View commit details
    Browse the repository at this point in the history

  70. Modify in-place in domain2dind

    @cphyc
    cphyc committed May 5, 2020
    Configuration menu
    Copy the full SHA
    7aed623 View commit details
    Browse the repository at this point in the history

  71. Entrance t should respect direction

    @cphyc
    cphyc committed May 5, 2020
    Configuration menu
    Copy the full SHA
    c2d239d View commit details
    Browse the repository at this point in the history

  72. Use bit magic to loop over root nodes

    @cphyc
    cphyc committed May 5, 2020
    Configuration menu
    Copy the full SHA
    3852759 View commit details
    Browse the repository at this point in the history

  73. Smaller complexity in proc_subtree

    @cphyc
    cphyc committed May 5, 2020
    Configuration menu
    Copy the full SHA
    6a4ea1d View commit details
    Browse the repository at this point in the history

  74. Use const kw if possible

    @cphyc
    cphyc committed May 5, 2020
    Configuration menu
    Copy the full SHA
    aa5c13f View commit details
    Browse the repository at this point in the history

  75. Pass entry min t-value down the recursion

    @cphyc
    cphyc committed May 5, 2020
    Configuration menu
    Copy the full SHA
    4faeca2 View commit details
    Browse the repository at this point in the history

  76. Move domain finding to standalone class

    @cphyc
    cphyc committed May 5, 2020
    Configuration menu
    Copy the full SHA
    301b4bd View commit details
    Browse the repository at this point in the history

  77. Hopefully correct magic

    @cphyc
    cphyc committed May 5, 2020
    Configuration menu
    Copy the full SHA
    60fb90d View commit details
    Browse the repository at this point in the history

  78. Need to explore the tree down to leafs, even when in wrong domain 

    This is because an oct that's not in the domain may contain cells from
multiple other domains, so we have to go down the tree until finding
the first leaf oct (or is it cell? Now I'm confused...) in another domain.
    @cphyc
    cphyc committed May 5, 2020
    Configuration menu
    Copy the full SHA
    cf83f57 View commit details
    Browse the repository at this point in the history

  79. Add trilinear interpolator

    @cphyc
    cphyc committed May 5, 2020
    Configuration menu
    Copy the full SHA
    28be7d8 View commit details
    Browse the repository at this point in the history

  80. Fix buffer dimension

    @cphyc
    cphyc committed May 5, 2020
    Configuration menu
    Copy the full SHA
    f1e28d6 View commit details
    Browse the repository at this point in the history

  81. Set things up for support of volume rendering + octree

    @cphyc
    cphyc committed May 5, 2020
    Configuration menu
    Copy the full SHA
    66e22e8 View commit details
    Browse the repository at this point in the history

  82. Adding nogil wherever possible

    @cphyc
    cphyc committed May 5, 2020
    Configuration menu
    Copy the full SHA
    f67ad4a View commit details
    Browse the repository at this point in the history

  83. Should compile

    @cphyc
    cphyc committed May 5, 2020
    Configuration menu
    Copy the full SHA
    1ff7856 View commit details
    Browse the repository at this point in the history

  84. First attempt

    @cphyc
    cphyc committed May 5, 2020
    Configuration menu
    Copy the full SHA
    e62d993 View commit details
    Browse the repository at this point in the history

  85. Function to describe each oct

    @cphyc
    cphyc committed May 5, 2020
    Configuration menu
    Copy the full SHA
    45f49f5 View commit details
    Browse the repository at this point in the history

  86. Wire things up to cast single ray from image sampler

    @cphyc
    cphyc committed May 5, 2020
    Configuration menu
    Copy the full SHA
    14bc969 View commit details
    Browse the repository at this point in the history

  87. Need to compile as C++

    @cphyc
    cphyc committed May 5, 2020
    Configuration menu
    Copy the full SHA
    29659e3 View commit details
    Browse the repository at this point in the history

  88. Call sampler from render

    @cphyc
    cphyc committed May 5, 2020
    Configuration menu
    Copy the full SHA
    880cbd5 View commit details
    Browse the repository at this point in the history