Addresses github issue #9896 #13
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Include 'cloud' part of the placement as well in 'topology-keys' property value - Exception handling improvements while getting a balanced connection when refreshing 'server list'. - Add 'debug' parameter to examples. - Add more debug level logs to help troubleshooting.
kneeraj
requested review from
suranjan,
ashetkar,
nchandrappa,
sanyamsinghal and
tedyu
tedyu
reviewed
Sep 1, 2021
| // Since it is just a demo app. Using some smaller values so that it can run | ||
| // on laptop | ||
| String numConnections = "6"; | ||
| String controlHost = "127.0.0.1"; | ||
| String controlPort = "5433"; | ||
|
|
||
| controlUrl = "jdbc:postgresql://" + controlHost | ||
| + ":" + controlPort + "/yugabyte?user=yugabyte&password=yugabyte&load-balance=true&topology-keys=region1.zone1"; | ||
|
|
||
| + ":" + controlPort + "/yugabyte?user=yugabyte&password=yugabyte&load-balance=true&topology-keys=cloud1.region1.zone1"; |
There was a problem hiding this comment.
This assignment to controlUrl can be enclosed in else block of the if block below.
| @@ -15,20 +15,27 @@ | |||
| protected static String controlUrl = ""; | |||
| protected static HikariDataSource hikariDataSource; | |||
| protected static Scanner scanner = new Scanner(System.in); | |||
| protected static List<Connection> borrowConnections = new ArrayList<>(); | |||
| protected static List<Connection> connectionsCreatedFroamApi = new ArrayList<>(); | |||
There was a problem hiding this comment.
Seems to be a typo: connectionsCreatedFroamApi -> connectionsCreatedFromApi
ashetkar
reviewed
Sep 2, 2021
|
|
||
| + ":" + controlPort + "/yugabyte?user=yugabyte&password=yugabyte&load-balance=true&topology-keys=cloud1.region1.zone1"; | ||
| if (debugLogging) { | ||
| controlUrl = "jdbc:postgresql://" + controlHost |
There was a problem hiding this comment.
nit: controlUrl = controlUrl + "&loggerLevel=debug";
Same in UniformLoadBalanceExample.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
property value
All Submissions:
New Feature Submissions:
Changes to Existing Features:
The value of property 'topology-keys' has to contain 'cloud' part also. App using previous version of the driver will have to change in how they specify topology-key value. Previously it was topology-keys=region1.zone1,region1.zone2 etc and now it is topology-keys=cloud1.region1.zone1,cloud1.region1.zone2