Skip to content

Commit

Permalink
[#9502] DST: PITR - Enabling PITR Unit Tests
Browse files Browse the repository at this point in the history 
Summary: Enabling 11 PITR unit test cases after the flakiness was fixed.

Test Plan:
 ./yb_build.sh --cxx-test yb-admin-snapshot-schedule-test --gtest_filter YbAdminSnapshotScheduleTest.PgsqlDropCheckConstraint
./yb_build.sh --cxx-test yb-admin-snapshot-schedule-test --gtest_filter YbAdminSnapshotScheduleTest.PgsqlAddUniqueConstraint
./yb_build.sh --cxx-test yb-admin-snapshot-schedule-test --gtest_filter YbAdminSnapshotScheduleTest.PgsqlDropUniqueConstraint
./yb_build.sh --cxx-test yb-admin-snapshot-schedule-test --gtest_filter YbAdminSnapshotScheduleTest.PgsqlAlterTableAddPK
./yb_build.sh --cxx-test yb-admin-snapshot-schedule-test --gtest_filter YbAdminSnapshotScheduleTest.PgsqlDropDefault
./yb_build.sh --cxx-test yb-admin-snapshot-schedule-test --gtest_filter YbAdminSnapshotScheduleTest.PgsqlSetNotNull
./yb_build.sh --cxx-test yb-admin-snapshot-schedule-test --gtest_filter YbAdminSnapshotScheduleTest.PgsqlSetDefault
./yb_build.sh --cxx-test yb-admin-snapshot-schedule-test --gtest_filter YbAdminSnapshotScheduleTest.PgsqlDropNotNull
./yb_build.sh --cxx-test yb-admin-snapshot-schedule-test --gtest_filter YbAdminSnapshotScheduleTest.PgsqlAlterTableSetOwner
./yb_build.sh --cxx-test yb-admin-snapshot-schedule-test --gtest_filter YbAdminSnapshotScheduleTest.PgsqlAlterTableAddFK
./yb_build.sh --cxx-test yb-admin-snapshot-schedule-test --gtest_filter YbAdminSnapshotScheduleTest.PgsqlAddCheckConstraint

# Tip: Create a dependency between revisions by writing "Depends on D123" in
# your summary.

Reviewers: nmantravadi, bogdan, skedia, mkantimath

Reviewed By: mkantimath

Subscribers: ybase

Differential Revision: https://phabricator.dev.yugabyte.com/D15443
  • Loading branch information
@kripasreenivasan
kripasreenivasan committed Feb 22, 2022
1 parent 2bf5468 commit 30f40b8
Showing 1 changed file with 12 additions and 11 deletions.
23 changes: 12 additions & 11 deletions src/yb/tools/yb-admin-snapshot-schedule-test.cc
View file
Original file line number Diff line number Diff line change
Expand Up @@ -795,7 +795,7 @@ TEST_F_EX(YbAdminSnapshotScheduleTest, YB_DISABLE_TEST_IN_TSAN(PgsqlRenameColumn
ASSERT_OK(conn.Execute("INSERT INTO test_table(key, value) VALUES (2, 'new_value')"));
}

TEST_F_EX(YbAdminSnapshotScheduleTest, YB_DISABLE_TEST(PgsqlSetDefault),
TEST_F_EX(YbAdminSnapshotScheduleTest, YB_DISABLE_TEST_IN_TSAN(PgsqlSetDefault),
YbAdminSnapshotScheduleTestWithYsql) {
auto schedule_id = ASSERT_RESULT(PreparePg());

Expand Down Expand Up @@ -832,7 +832,7 @@ TEST_F_EX(YbAdminSnapshotScheduleTest, YB_DISABLE_TEST(PgsqlSetDefault),
ASSERT_EQ(result_status.ok(), false);
}

TEST_F_EX(YbAdminSnapshotScheduleTest, YB_DISABLE_TEST(PgsqlDropDefault),
TEST_F_EX(YbAdminSnapshotScheduleTest, YB_DISABLE_TEST_IN_TSAN(PgsqlDropDefault),
YbAdminSnapshotScheduleTestWithYsql) {
auto schedule_id = ASSERT_RESULT(PreparePg());

Expand Down Expand Up @@ -875,7 +875,7 @@ TEST_F_EX(YbAdminSnapshotScheduleTest, YB_DISABLE_TEST(PgsqlDropDefault),
ASSERT_EQ(result_status.ok(), false);
}

TEST_F_EX(YbAdminSnapshotScheduleTest, YB_DISABLE_TEST(PgsqlSetNotNull),
TEST_F_EX(YbAdminSnapshotScheduleTest, YB_DISABLE_TEST_IN_TSAN(PgsqlSetNotNull),
YbAdminSnapshotScheduleTestWithYsql) {
auto schedule_id = ASSERT_RESULT(PreparePg());

Expand Down Expand Up @@ -906,7 +906,7 @@ TEST_F_EX(YbAdminSnapshotScheduleTest, YB_DISABLE_TEST(PgsqlSetNotNull),
ASSERT_EQ(res3, "");
}

TEST_F_EX(YbAdminSnapshotScheduleTest, YB_DISABLE_TEST(PgsqlDropNotNull),
TEST_F_EX(YbAdminSnapshotScheduleTest, YB_DISABLE_TEST_IN_TSAN(PgsqlDropNotNull),
YbAdminSnapshotScheduleTestWithYsql) {
auto schedule_id = ASSERT_RESULT(PreparePg());

Expand Down Expand Up @@ -937,7 +937,7 @@ TEST_F_EX(YbAdminSnapshotScheduleTest, YB_DISABLE_TEST(PgsqlDropNotNull),
ASSERT_NOK(conn.Execute("INSERT INTO test_table VALUES (3)"));
}

TEST_F_EX(YbAdminSnapshotScheduleTest, YB_DISABLE_TEST(PgsqlAlterTableAddPK),
TEST_F_EX(YbAdminSnapshotScheduleTest, YB_DISABLE_TEST_IN_TSAN(PgsqlAlterTableAddPK),
YbAdminSnapshotScheduleTestWithYsql) {
auto schedule_id = ASSERT_RESULT(PreparePg());

Expand Down Expand Up @@ -969,7 +969,7 @@ TEST_F_EX(YbAdminSnapshotScheduleTest, YB_DISABLE_TEST(PgsqlAlterTableAddPK),
ASSERT_OK(conn.Execute("INSERT INTO test_table VALUES (1, 'AfterPKRemoval')"));
}

TEST_F_EX(YbAdminSnapshotScheduleTest, YB_DISABLE_TEST(PgsqlAlterTableAddFK),
TEST_F_EX(YbAdminSnapshotScheduleTest, YB_DISABLE_TEST_IN_TSAN(PgsqlAlterTableAddFK),
YbAdminSnapshotScheduleTestWithYsql) {
auto schedule_id = ASSERT_RESULT(PreparePg());

Expand Down Expand Up @@ -999,7 +999,7 @@ TEST_F_EX(YbAdminSnapshotScheduleTest, YB_DISABLE_TEST(PgsqlAlterTableAddFK),
ASSERT_OK(conn.Execute("DROP TABLE test_table"));
}

TEST_F_EX(YbAdminSnapshotScheduleTest, YB_DISABLE_TEST(PgsqlAlterTableSetOwner),
TEST_F_EX(YbAdminSnapshotScheduleTest, YB_DISABLE_TEST_IN_TSAN(PgsqlAlterTableSetOwner),
YbAdminSnapshotScheduleTestWithYsql) {
auto schedule_id = ASSERT_RESULT(PreparePg());

Expand Down Expand Up @@ -1050,7 +1050,7 @@ TEST_F_EX(YbAdminSnapshotScheduleTest, YB_DISABLE_TEST(PgsqlAlterTableSetOwner),
ASSERT_OK(conn.Execute("ALTER TABLE test_table RENAME key TO key_new3"));
}

TEST_F_EX(YbAdminSnapshotScheduleTest, YB_DISABLE_TEST(PgsqlAddUniqueConstraint),
TEST_F_EX(YbAdminSnapshotScheduleTest, YB_DISABLE_TEST_IN_TSAN(PgsqlAddUniqueConstraint),
YbAdminSnapshotScheduleTestWithYsql) {
auto schedule_id = ASSERT_RESULT(PreparePg());

Expand Down Expand Up @@ -1078,7 +1078,7 @@ TEST_F_EX(YbAdminSnapshotScheduleTest, YB_DISABLE_TEST(PgsqlAddUniqueConstraint)
ASSERT_OK(conn.Execute("INSERT INTO test_table VALUES (2, 'ABC')"));
}

TEST_F_EX(YbAdminSnapshotScheduleTest, YB_DISABLE_TEST(PgsqlDropUniqueConstraint),
TEST_F_EX(YbAdminSnapshotScheduleTest, YB_DISABLE_TEST_IN_TSAN(PgsqlDropUniqueConstraint),
YbAdminSnapshotScheduleTestWithYsql) {
auto schedule_id = ASSERT_RESULT(PreparePg());

Expand Down Expand Up @@ -1119,7 +1119,8 @@ TEST_F_EX(YbAdminSnapshotScheduleTest, YB_DISABLE_TEST(PgsqlDropUniqueConstraint
ASSERT_EQ(result_status.ok(), false);
}

TEST_F_EX(YbAdminSnapshotScheduleTest, YB_DISABLE_TEST(PgsqlAddCheckConstraint),

TEST_F_EX(YbAdminSnapshotScheduleTest, YB_DISABLE_TEST_IN_TSAN(PgsqlAddCheckConstraint),
YbAdminSnapshotScheduleTestWithYsql) {
auto schedule_id = ASSERT_RESULT(PreparePg());

Expand Down Expand Up @@ -1147,7 +1148,7 @@ TEST_F_EX(YbAdminSnapshotScheduleTest, YB_DISABLE_TEST(PgsqlAddCheckConstraint),
ASSERT_OK(conn.Execute("INSERT INTO test_table VALUES (2, 'PQR')"));
}

TEST_F_EX(YbAdminSnapshotScheduleTest, YB_DISABLE_TEST(PgsqlDropCheckConstraint),
TEST_F_EX(YbAdminSnapshotScheduleTest, YB_DISABLE_TEST_IN_TSAN(PgsqlDropCheckConstraint),
YbAdminSnapshotScheduleTestWithYsql) {
auto schedule_id = ASSERT_RESULT(PreparePg());

Expand Down

0 comments on commit 30f40b8

Please sign in to comment.