Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YSQL] Distinguish temp and foreign tables for batch COPY #11633

Closed
tedyu opened this issue Mar 2, 2022 · 0 comments
Closed

[YSQL] Distinguish temp and foreign tables for batch COPY #11633

tedyu opened this issue Mar 2, 2022 · 0 comments
Assignees
Labels
area/ysql Yugabyte SQL (YSQL)

Comments

@tedyu
Copy link
Contributor

tedyu commented Mar 2, 2022

Description

In CopyFrom(), currently we regard non-YB table as TEMP table.

However, this produces confusing message for FOREIGN table:

ts1|pid52548|:30139 2022-03-01 09:16:20.854 UTC [52764] WARNING:  Batched COPY is not supported on temporary tables. Defaulting to using one transaction for the entire copy.

This revision checks the Relation type and uses proper table type in the message.

@tedyu tedyu added the area/ysql Yugabyte SQL (YSQL) label Mar 2, 2022
@tedyu tedyu self-assigned this Mar 2, 2022
tedyu added a commit that referenced this issue Mar 3, 2022
Summary:
In CopyFrom(), currently we regard non-YB table as TEMP table.

However, this produces confusing message for FOREIGN table:
```
ts1|pid52548|:30139 2022-03-01 09:16:20.854 UTC [52764] WARNING:  Batched COPY is not supported on temporary tables. Defaulting to using one transaction for the entire copy.
```
This revision checks the Relation type and uses proper table type in the message.

Test Plan: ybd --java-test 'org.yb.pgsql.TestPgRegressContribPostgresFdw#schedule'

Reviewers: ena, myang

Reviewed By: myang

Subscribers: yql

Differential Revision: https://phabricator.dev.yugabyte.com/D15734
@tedyu tedyu closed this as completed Mar 3, 2022
jayant07-yb pushed a commit to jayant07-yb/yugabyte-db that referenced this issue Mar 8, 2022
Summary:
In CopyFrom(), currently we regard non-YB table as TEMP table.

However, this produces confusing message for FOREIGN table:
```
ts1|pid52548|:30139 2022-03-01 09:16:20.854 UTC [52764] WARNING:  Batched COPY is not supported on temporary tables. Defaulting to using one transaction for the entire copy.
```
This revision checks the Relation type and uses proper table type in the message.

Test Plan: ybd --java-test 'org.yb.pgsql.TestPgRegressContribPostgresFdw#schedule'

Reviewers: ena, myang

Reviewed By: myang

Subscribers: yql

Differential Revision: https://phabricator.dev.yugabyte.com/D15734
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ysql Yugabyte SQL (YSQL)
Projects
None yet
Development

No branches or pull requests

1 participant