Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YSQL] Protobuf Log Line Spamming (String field contains invalid UTF-8 data) #11693

Closed
nathanhjli opened this issue Mar 8, 2022 · 1 comment
Assignees
Labels
area/ysql Yugabyte SQL (YSQL)

Comments

@nathanhjli
Copy link
Contributor

nathanhjli commented Mar 8, 2022

Description

Running any operation (COPY, INSERT, UPDATE, CREATE) on latest master branch leads to a lot of the same log line being spammed:

[libprotobuf ERROR google/protobuf/wire_format_lite.cc:629] String field 'yb.PgsqlWriteRequestPB.partition_key' contains invalid UTF-8 data when serializing a protocol buffer. Use the 'bytes' type if you intend to send raw bytes.

We need to confirm if this is an issue or just spam.

Might be related to @spolitov 's recent changes to write/read operations.

@nathanhjli nathanhjli added the area/ysql Yugabyte SQL (YSQL) label Mar 8, 2022
spolitov added a commit that referenced this issue Mar 9, 2022
Summary:
partition_key was added to PgsqlWriteRequestPB in recent c5f5125/D13244 commit.
The field has type string, but it could contain arbitrary data, so bytes type should be used for it.
This diff fixes the issue by switching to bytes type.

Test Plan: Jenkins

Reviewers: dmitry

Reviewed By: dmitry

Subscribers: bogdan, ybase

Differential Revision: https://phabricator.dev.yugabyte.com/D15877
@bmatican
Copy link
Contributor

bmatican commented Mar 9, 2022

Fixed. Related to the work in #9936

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ysql Yugabyte SQL (YSQL)
Projects
Status: No status
Development

No branches or pull requests

3 participants