[DocDB] [PITR] Turn consistent_restore flag on by default #12853
Assignees
Labels
2.18 Backport Required
area/docdb
YugabyteDB core features
kind/enhancement
This is an enhancement of an existing feature
priority/high
High Priority
Comments
vkulichenko
added
area/docdb
yugabyte-ci
added
kind/bug
yugabyte-ci
added
kind/enhancement
yugabyte-ci
added
priority/high
yamen-haddad
added a commit
that referenced
this issue
Jul 11, 2023
Summary: In order to provide consistency guarantees if PITR restore is executed concurrently with transactions updating the data, the recommendation is to stop application workloads before initiating the restore. There is a `consistent_restore` flag (introduced in #8419) that provides these guarantees. However, the flag is not enabled by default as it needed to be thoroughly tested. Now that the flag has been validated by QA, this diff sets the default value of `consistent_restore` to true. Jira: DB-2615 Test Plan: QA has validated `consistent_restore` flag. Unit tests where the flags is enabled: ybd --gtest_filter YbAdminSnapshotScheduleTest.ConsistentRestore ybd --gtest_filter YbAdminSnapshotScheduleTest.ConsistentTxnRestore Reviewers: zdrudi, skedia Reviewed By: zdrudi Subscribers: ybase, bogdan, slingam Differential Revision: https://phorge.dev.yugabyte.com/D26681
yamen-haddad
added a commit
that referenced
this issue
Aug 14, 2023
… by default Summary: Original commit: 4b167e7 / D26681 In order to provide consistency guarantees if PITR restore is executed concurrently with transactions updating the data, the recommendation is to stop application workloads before initiating the restore. There is a `consistent_restore` flag (introduced in #8419) that provides these guarantees. However, the flag is not enabled by default as it needed to be thoroughly tested. Now that the flag has been validated by QA, this diff sets the default value of `consistent_restore` to true. Jira: DB-2615 Test Plan: QA has validated `consistent_restore` flag. Unit tests where the flags is enabled: ybd --gtest_filter YbAdminSnapshotScheduleTest.ConsistentRestore ybd --gtest_filter YbAdminSnapshotScheduleTest.ConsistentTxnRestore Reviewers: zdrudi, skedia Reviewed By: zdrudi Subscribers: slingam, bogdan, ybase Differential Revision: https://phorge.dev.yugabyte.com/D27748
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Jira Link: DB-2615
Description
Currently, we do not provide consistency guarantees if PITR restore is executed concurrently with transactions updating the data. The recommendation is to stop application workloads prior to initiating the restore.
There is a
consistent_restoreflag (introduced in #8419) that changes this behavior, but it's not enabled by default.We need to thoroughly test the scenario and turn on the flag by default.
The text was updated successfully, but these errors were encountered: