Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YSQL] Import Pgtap extension #13254

Closed
averyshum62 opened this issue Jul 11, 2022 · 0 comments
Closed

[YSQL] Import Pgtap extension #13254

averyshum62 opened this issue Jul 11, 2022 · 0 comments
Assignees
Labels
area/ysql Yugabyte SQL (YSQL) kind/enhancement This is an enhancement of an existing feature priority/medium Medium priority issue

Comments

@averyshum62
Copy link
Contributor

averyshum62 commented Jul 11, 2022

Jira Link: DB-2904

Description

The Pgtap extension is currently not supported in Yugabyte (https://pgtap.org/documentation.html).

pgTap is a suite of database functions that make it easy to write unit tests in psql scripts.

@averyshum62 averyshum62 added area/ysql Yugabyte SQL (YSQL) status/awaiting-triage Issue awaiting triage labels Jul 11, 2022
@yugabyte-ci yugabyte-ci added kind/bug This issue is a bug priority/medium Medium priority issue labels Jul 11, 2022
@averyshum62 averyshum62 self-assigned this Jul 11, 2022
@yugabyte-ci yugabyte-ci removed the status/awaiting-triage Issue awaiting triage label Jul 20, 2022
@yugabyte-ci yugabyte-ci added kind/enhancement This is an enhancement of an existing feature and removed kind/bug This issue is a bug labels Aug 23, 2022
jasonyb pushed a commit that referenced this issue Jul 24, 2024
Summary:
Subtree merge pgtap into
src/postgres/third-party-extensions/pgtap.

pgtap repo: https://github.com/theory/pgtap/tree/v1.3.3

Ran the following:

```
git remote add pgtap https://github.com/theory/pgtap.git
git fetch pgtap v1.3.3:tags/v1.3.3
git subtree add --prefix=src/postgres/third-party-extensions/pgtap pgtap v1.3.3
```

Chose v1.3.3 as it is the latest released version and requires PostgreSQL 9.1 or higher.
Mentioned in their [[ https://github.com/theory/pgtap/blob/v1.3.3/README.md#dependencies | README ]] also.
Integrating pgtap into the build will be done as a followup.
Jira: DB-2904

Test Plan: jenkins: compile only

Reviewers: jason, skumar, hsunder

Reviewed By: jason, hsunder

Subscribers: steve.varnau, yql

Differential Revision: https://phorge.dev.yugabyte.com/D36612
devansh-ism pushed a commit that referenced this issue Jul 25, 2024
Summary:
This diff integrates pgtap extension to build by adding it to third-party directory makefile
Jira: DB-2904

Test Plan: jenkins: compile-only

Reviewers: hsunder, jason

Reviewed By: jason

Subscribers: yql

Differential Revision: https://phorge.dev.yugabyte.com/D36772
jasonyb pushed a commit that referenced this issue Jul 25, 2024
Summary:
 5aa0c0a [PLAT-14078] Add local provider test for update databases
 cdd97f8 remove ea badge (#23276)
 2813d78 [PLAT-14156][PLAT-14323]: Move all UI Driven flags to INTERNAL and remove YBM key as its not used
 49523f5 [PLAT-14733]: Add support for OIDC attributes jwt_jwks_path and jwt_jwks_url
 b039d1a [PLAT-14366] Basic local provider test for master auto failover
 700fd49 [#23275] docdb: Fix missing home icon on master UI
 89e434e [#13254] YSQL: import pgtap v1.3.3
 1b3585f [doc][cdc] Updated diagrams (#23262)
 399f165 [#23266] YSQL: Only require YB Admin privileges to run pg_locks
 5a4bbd4 [#19954] docdb: Register both tablet split children atomically
 b4c4294 [PLAT-14617] Add support for numerical search and enable extra search fields forxCluster
 84fb7ad [#22449] YSQL: wal2json YB specific changes
 afe84d4 [#13254] YSQL: add pgtap to build
 adf3c54 [#23272] YSQL, ASH: Fix incorrect popping of query id from nested query ids stack
 3b42c2e [docs] Add syntax documentation for logical replication (#23270)

Test Plan: Jenkins: rebase: pg15-cherrypicks

Reviewers: jason, tfoucher

Tags: #jenkins-ready

Differential Revision: https://phorge.dev.yugabyte.com/D36841
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ysql Yugabyte SQL (YSQL) kind/enhancement This is an enhancement of an existing feature priority/medium Medium priority issue
Projects
None yet
Development

No branches or pull requests

3 participants