Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[xCluster] Dont use Database Consistency during login #14607

Closed
hari90 opened this issue Oct 21, 2022 · 0 comments
Closed

[xCluster] Dont use Database Consistency during login #14607

hari90 opened this issue Oct 21, 2022 · 0 comments
Assignees
@hari90
Labels
area/docdb YugabyteDB core features kind/bug This issue is a bug priority/medium Medium priority issue

Comments

@hari90
Copy link
Contributor

hari90 commented Oct 21, 2022 •
edited
Loading

Jira Link: DB-3978

Description

Dont use Database Consistency during login
@hari90 hari90 added area/docdb YugabyteDB core features status/awaiting-triage Issue awaiting triage labels Oct 21, 2022
@yugabyte-ci yugabyte-ci added kind/bug This issue is a bug priority/medium Medium priority issue labels Oct 21, 2022
@hari90 hari90 changed the title [xCluster] Done use Database Consistency during login [xCluster] Dont use Database Consistency during login Oct 21, 2022
@hari90 hari90 self-assigned this Oct 21, 2022
@hari90 hari90 added kind/enhancement This is an enhancement of an existing feature and removed kind/bug This issue is a bug priority/medium Medium priority issue status/awaiting-triage Issue awaiting triage labels Oct 21, 2022
@yugabyte-ci yugabyte-ci added kind/bug This issue is a bug priority/medium Medium priority issue and removed kind/enhancement This is an enhancement of an existing feature labels Oct 21, 2022
@hari90 hari90 closed this as completed in 27fa5c5 Nov 15, 2022
@hari90 hari90 mentioned this issue Nov 15, 2022
Closed
hari90 added a commit that referenced this issue Nov 17, 2022
@hari90
[BACKPORT 2.17.0][#14607,#15026] xCluster: Use tablet level xCluster …
53400b3 
…consistency during read of catalog only data

Summary:
Original commit: 27fa5c5 / D21003
cf0fbb7 / D21130
Catalog only reads like authentication, and \dt should use latest reads (tablet level consistency), as we always want to read latest data in non-user system tables. This makes sure we always respect the latest databases security policies like users, and roles.

Also when the safe time for the database is not valid yet, it allows us to still start a connection. We can then set `yb_xcluster_consistency_level` to `tablet` if needed and access the partial data.

Fixes #14607

Test Plan: XClusterConsistencyTest

Reviewers: slingam, myang, rahuldesirazu, dmitry

Reviewed By: dmitry

Subscribers: ybase, dmitry

Differential Revision: https://phabricator.dev.yugabyte.com/D21107
jayant07-yb pushed a commit to jayant07-yb/yugabyte-db that referenced this issue Dec 7, 2022
@hari90
[yugabyte#14607] xCluster: Use tablet level xCluster consistency duri…
1b867d9 
…ng read of catalog only data

Summary:
Catalog only reads like authentication, and \dt should use latest reads (tablet level consistency), as we always want to read latest data in non-user system tables. This makes sure we always respect the latest databases security policies like users, and roles.

Also when the safe time for the database is not valid yet, it allows us to still start a connection. We can then set `yb_xcluster_consistency_level` to `tablet` if needed and access the partial data.

Fixes yugabyte#14607

Test Plan: XClusterConsistencyTest

Reviewers: slingam, myang, rahuldesirazu, dmitry

Reviewed By: rahuldesirazu

Subscribers: dmitry, ybase

Differential Revision: https://phabricator.dev.yugabyte.com/D21003
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hari90 hari90

Labels
area/docdb YugabyteDB core features kind/bug This issue is a bug priority/medium Medium priority issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hari90 @yugabyte-ci