Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[YSQL] Populate wait queue lock-info from tservers in yb_lock_status #14850

Closed
pkj415 opened this issue Nov 4, 2022 · 0 comments
Closed

[YSQL] Populate wait queue lock-info from tservers in yb_lock_status #14850

pkj415 opened this issue Nov 4, 2022 · 0 comments
Assignees
@basavaraj29
Labels
area/docdb YugabyteDB core features kind/enhancement This is an enhancement of an existing feature priority/medium Medium priority issue

Comments

@pkj415
Copy link
Contributor

pkj415 commented Nov 4, 2022 •
edited by robertsami
Loading

Jira Link: DB-4147

Description

Our initial implementation looks only at intents_db. We should also populate pg_locks with information from wait queues
@pkj415 pkj415 added area/ysql Yugabyte SQL (YSQL) status/awaiting-triage Issue awaiting triage labels Nov 4, 2022
@yugabyte-ci yugabyte-ci added kind/bug This issue is a bug priority/medium Medium priority issue labels Nov 4, 2022
@pkj415 pkj415 mentioned this issue Nov 4, 2022
Closed
@yugabyte-ci yugabyte-ci added kind/enhancement This is an enhancement of an existing feature and removed kind/bug This issue is a bug status/awaiting-triage Issue awaiting triage labels Dec 12, 2022
@robertsami robertsami changed the title [YSQL] Populate wait queue information from tservers in pg_locks [YSQL] Populate wait queue information from tservers in yb_lock_status Jan 17, 2023
@robertsami robertsami changed the title [YSQL] Populate wait queue information from tservers in yb_lock_status [YSQL] Populate wait queue lock-info from tservers in yb_lock_status Jan 17, 2023
@robertsami robertsami self-assigned this Jan 17, 2023
@robertsami robertsami assigned basavaraj29 and unassigned robertsami May 12, 2023
@yugabyte-ci yugabyte-ci added area/docdb YugabyteDB core features and removed area/ysql Yugabyte SQL (YSQL) labels May 22, 2023
basavaraj29 added a commit that referenced this issue Jun 20, 2023
@basavaraj29
[#14850] DocDB: Populate wait queue lock-info from tservers in yb_loc…
a4b5eb8 
…k_status

Summary:
Previously, we populated the lock information with acquired locks of in progress transactions alone. This diff augments the response by populating the awaiting lock info from the wait queue. The semantics remain the same, i.e. when no transactions are given, we return info of all waiter transactions. And when a non-empty set of transaction is passed, we restrict the results to that set only.

One awaiting action - the `subtransaction_id` and `is_explicit` fields for the awaiting lock info of waiter transaction are not being populated. Will take that up in a subsequent iteration/diff based on the requirement.
Jira: DB-4147

Test Plan: ./yb_build.sh --cxx-test pgwrapper_pg_get_lock_status-test --gtest_filter PgGetLockStatusTest.TestLocksFromWaitQueue

Reviewers: rsami, pjain

Reviewed By: rsami

Subscribers: ybase

Differential Revision: https://phorge.dev.yugabyte.com/D25257
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@basavaraj29 basavaraj29

Labels
area/docdb YugabyteDB core features kind/enhancement This is an enhancement of an existing feature priority/medium Medium priority issue
Projects
Wait-Queue Based Locking
Status: Done
Milestone
No milestone
Development

No branches or pull requests
4 participants
@robertsami @pkj415 @yugabyte-ci @basavaraj29