Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[YSQL] Enable support for ALTER TABLE IF EXISTS t RENAME command #23011

Closed
1 task done
fizaaluthra opened this issue Jun 25, 2024 · 1 comment
Closed
1 task done

[YSQL] Enable support for ALTER TABLE IF EXISTS t RENAME command #23011

fizaaluthra opened this issue Jun 25, 2024 · 1 comment
Assignees
@OlegLoginov
Labels
area/ysql Yugabyte SQL (YSQL) kind/enhancement This is an enhancement of an existing feature priority/medium Medium priority issue

Comments

@fizaaluthra
Copy link
Member

fizaaluthra commented Jun 25, 2024 •
edited by OlegLoginov
Loading

Jira Link: DB-11940

Description

ALTER TABLE IF_P EXISTS relation_expr RENAME opt_column name TO name

Note: the following syntax is already supported

ALTER TABLE relation_expr RENAME opt_column name TO name

Issue Type

kind/enhancement

Warning: Please confirm that this issue does not contain any sensitive information

  • I confirm this issue does not contain any sensitive information.
@fizaaluthra fizaaluthra added area/ysql Yugabyte SQL (YSQL) status/awaiting-triage Issue awaiting triage labels Jun 25, 2024
@yugabyte-ci yugabyte-ci added kind/enhancement This is an enhancement of an existing feature priority/medium Medium priority issue labels Jun 25, 2024
@OlegLoginov OlegLoginov removed the status/awaiting-triage Issue awaiting triage label Jul 3, 2024
@OlegLoginov
Copy link
Contributor

Moving ALTER TABLE ... SET SCHEMA ... into #23114

@OlegLoginov OlegLoginov changed the title [YSQL] Enable support for some ALTER TABLE commands [YSQL] Enable support for ALTER TABLE IF EXISTS t RENAME command Jul 3, 2024
OlegLoginov added a commit that referenced this issue Jul 22, 2024
@OlegLoginov
[#23011] YSQL: Enable ALTER TABLE IF EXISTS t RENAME c1 TO c2
50422f8 
Summary:
Enabled YSQL `ALTER TABLE IF EXISTS ... RENAME ... TO ...` syntax.
In fact the needed internal functionality was already implemented in the functions: `renameatt` and `YBCRename`,
but the command was disabled at the grammar level.

The diff also adds several test-cases for the syntax:
* `ALTER TABLE IF EXISTS ...` (new enabled functionality)
* `ALTER TABLE ... RENAME COLUMN ...`
* Plus minor changes for `ALTER TABLE ... RENAME ...`
Jira: DB-11940

Test Plan:
./yb_build.sh --java-test org.yb.pgsql.TestPgRegressFeature#testPgRegressFeature
./yb_build.sh --java-test org.yb.pgsql.TestPgRegressTable#testPgRegressTable

Reviewers: mihnea, fizaa, jason

Reviewed By: jason

Subscribers: jason, yql

Differential Revision: https://phorge.dev.yugabyte.com/D36390
jasonyb pushed a commit that referenced this issue Jul 23, 2024
@jaki
[BACKPORT pg15-cherrypicks] all: Bulk port from master - 60+61
d517b7e 
Summary:
5a76f6a [#23179] CDCSDK: Support data types with dynamically alloted oids in CDC
5820ccd [PLAT-14710] Do not return apiToken in response to getSessionInfo
dcfa9cd [docs] updates to CVE table status column (#23225)
c0b1ee8 [docs] Fix load balance keyword in drivers page (#23253)
2becb46 [docs] Add basic troubleshooting steps for read restart errors. (#23228)
1b9be2e [PLAT-12733] Kubernetes overrides in v2 api
50422f8 [#23011] YSQL: Enable ALTER TABLE IF EXISTS t RENAME c1 TO c2
7c55b95 [PLAT-14073] DB scoped failover+repair
5ac65eb [#22449] YSQL: import wal2json wal2json_2_6
9e046fb [#23163] YSQL: pg_partman: make 'inherit_template_properties' idempotent
2248dcd [#23163] YSQL: pg_partman: make 'apply_publications' idempotent
7b32d05 [#23163] YSQL: pg_partman: Make partition creation idempotent
b0349fe [PLAT-14710] update api doc for /session_info
fe37ffd [#23240] CDCSDK: Make test replicationConnectionConsumptionAllDataTypes more resilient

Test Plan: Jenkins: rebase: pg15-cherrypicks

Reviewers: tfoucher

Tags: #jenkins-ready

Differential Revision: https://phorge.dev.yugabyte.com/D36789
@m-iancu m-iancu closed this as completed Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@OlegLoginov OlegLoginov

Labels
area/ysql Yugabyte SQL (YSQL) kind/enhancement This is an enhancement of an existing feature priority/medium Medium priority issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@m-iancu @yugabyte-ci @fizaaluthra @OlegLoginov