Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YSQL] Use PG15 system table in testing #23799

Closed
1 task done
OlegLoginov opened this issue Sep 4, 2024 · 1 comment
Closed
1 task done

[YSQL] Use PG15 system table in testing #23799

OlegLoginov opened this issue Sep 4, 2024 · 1 comment
Assignees
Labels
area/ysql Yugabyte SQL (YSQL) kind/enhancement This is an enhancement of an existing feature kind/failing-test Tests and testing infra priority/medium Medium priority issue

Comments

@OlegLoginov
Copy link
Contributor

OlegLoginov commented Sep 4, 2024

Jira Link: DB-12701

Description

This issue is for PG15 support mainly.
The idea is in using in the YSQL testing only the PG system tables which are available in both branches - in PG11 & PG15.
Just to unify & simplify the testing process & the moving to the PG15 baseline.

The failed test is:
./yb_build.sh --cxx-test pgwrapper_pg_table_size-test --gtest_filter PgTableSizeTest.SharedTableSize
because it uses pg_pltemplate table, which is not supported in PG15. (It's available in PG11 & PG12.)

Issue Type

kind/failing-test

Warning: Please confirm that this issue does not contain any sensitive information

  • I confirm this issue does not contain any sensitive information.
@OlegLoginov OlegLoginov added area/ysql Yugabyte SQL (YSQL) kind/failing-test Tests and testing infra labels Sep 4, 2024
@OlegLoginov OlegLoginov self-assigned this Sep 4, 2024
@yugabyte-ci yugabyte-ci added priority/medium Medium priority issue kind/enhancement This is an enhancement of an existing feature labels Sep 4, 2024
OlegLoginov added a commit that referenced this issue Sep 4, 2024
Summary:
The test `PgTableSizeTest.SharedTableSize` was checking the size of
the shared tables: `pg_auth_members` & `pg_pltemplate`.
For PG15 the table `pg_pltemplate` (supported till PG12 only) is replaced
by `pg_authid`, because the table is not available in PG15.

The fix is implemented in the `master` branch to have it sync-ed with
the `pg15` branch.
Jira: DB-12701

Test Plan: ./yb_build.sh --cxx-test pgwrapper_pg_table_size-test --gtest_filter PgTableSizeTest.SharedTableSize

Reviewers: mihnea, jason, sushil.kumar

Reviewed By: jason

Subscribers: yql

Differential Revision: https://phorge.dev.yugabyte.com/D37718
@OlegLoginov
Copy link
Contributor Author

To be backported into pg15 branch.

jasonyb pushed a commit that referenced this issue Sep 6, 2024
Summary:
 c587efd [docs] minor edit (#23796)
 31e09f3 [PLAT-15029] yba installer split data and software directory setup
 f5ba17d [PLAT-15039]: Fix bootstrap on bi-directional xCluster config creation
 578248a [#23770] YSQL: Deterministically populate catalog cache in tests with Connection Manager enabled
 7b1f22a [#23799] test: Fixed PgTableSizeTest.SharedTableSize test for pg15
 788434a [#18771, #21352] docdb: Fix LightweightMessage max size when parsing
 02ced43 [#22821] YSQL: Preserve local limit in a multi-page read
 50ff737 [#23741] docdb: Fix cloning of colocated databases with only parent table
 Excluded: 9889df7 [#23706] YSQL: Add table-level catcache Prometheus metrics
 c770d79 [#23747] MetaCache: Callback should not be called while holding the lock
 Excluded: 40689bc [#22150] YSQL, QueryDiagnostics:  EXPLAIN (ANALYZE, DIST) support for queryDiagnostics
 1655e69 [PLAT-15148]: Set XCluster Table Status to DroppedFromTarget if table in replication is dropped from target only
 16262f7 [#22519] YSQL: Simplify API of the ExplicitRowLockBuffer class
 6614afb [PLAT-14958][PLAT-14959] Make ssh fields optional if skipProvisioning is true
 1153b56 [PLAT-14867] Make sure restart alerts don't trigger for small time updates during NTP sync
 bf1c7bc [PLAT-12226] Add connection pooling status to universe health check
 38d8ae8 [PLAT-14805]Support adding EAR configs
 a180bef [#19134] YSQL, ASH: Setting ASH circular buffer size based on the number of cores
 7d8fc76 Adjust heading link (#23807)
 4c6cf5a [PLAT-4899]Basic validation of certificates
 f24eb10 [#23787] YSQL: Avoid executing conn mgr guc variables hooks for parallel workers
 ee18df8 [PLAT-13921] [K8] [UI] Universe action tasks are disabled after a failed shrink rr node task
 Excluded: dcf1821 [#23797] YSQL: Modify some tests to run in single connection mode with Connection Manager
 0ac22cd [Docs] Remove Drift chat bot (#23802)
 0e91003 [#22825] DocDB: Vector Index General Read Path with DummyANN
 e8f09b5 [PLAT-15175] Make runtime conf for skipping cluster consistency check public
 ee479ee Versionwarning (#23781)
 a05c6a3 [DB-12681] yugabyted-ui: Add Voyager commands to different Voyager phases in the UI.
 cc80d59 [#23777] yugabyted: updating the pg parity testcase to reflect the new gflags enabled for the pg parity feature.

Test Plan: Jenkins: rebase: pg15-cherrypicks

Reviewers: jason, tfoucher

Subscribers: yql

Differential Revision: https://phorge.dev.yugabyte.com/D37822
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ysql Yugabyte SQL (YSQL) kind/enhancement This is an enhancement of an existing feature kind/failing-test Tests and testing infra priority/medium Medium priority issue
Projects
Status: Done
Development

No branches or pull requests

2 participants