Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DocDB] tsan test failures being caused by when stack tracing is enabled #23841

Closed
1 task done
basavaraj29 opened this issue Sep 9, 2024 · 0 comments
Closed
1 task done

[DocDB] tsan test failures being caused by when stack tracing is enabled #23841

basavaraj29 opened this issue Sep 9, 2024 · 0 comments
Assignees
@es1024
Labels
2024.1 Backport Required area/docdb YugabyteDB core features kind/bug This issue is a bug priority/medium Medium priority issue

Comments

@basavaraj29
Copy link
Contributor

basavaraj29 commented Sep 9, 2024 •
edited by jira bot
Loading

Jira Link: DB-12745

Description

A couple of tests are failing in tsan starting from commit.

  1. DataPatcherTest.AddTimeDelta
  2. SnapshotTxnTest.DeleteOnLoad/0, SnapshotTxnTest.DeleteOnErroredLoad/0, FailOnConflict/SnapshotTxnTest.DeleteOnErroredLoad/0
  3. PgLeaderChangeWaitQueuesTest.AddTwoServersDelayBlockerStatusRpcCallback

As a workaround, we can disable stack tracing in tsan to catch actual tsan regressions.

Issue Type

kind/bug

Warning: Please confirm that this issue does not contain any sensitive information

  • I confirm this issue does not contain any sensitive information.
@basavaraj29 basavaraj29 added area/docdb YugabyteDB core features status/awaiting-triage Issue awaiting triage labels Sep 9, 2024
@yugabyte-ci yugabyte-ci added kind/bug This issue is a bug priority/medium Medium priority issue labels Sep 9, 2024
@yugabyte-ci yugabyte-ci removed the status/awaiting-triage Issue awaiting triage label Sep 9, 2024
@rthallamko3 rthallamko3 removed their assignment Sep 9, 2024
es1024 added a commit that referenced this issue Sep 11, 2024
@es1024
[#23841] docdb: Disable stack trace tracking in TSAN builds
e86951a 
Summary:
Stack trace tracking adds a performance penalty causing various tests to fail in TSAN
builds. This diff disables stack trace tracking in TSAN builds.
Jira: DB-12745

Test Plan: Jenkins: build type: tsan, cpp only

Reviewers: bkolagani

Reviewed By: bkolagani

Subscribers: ybase

Differential Revision: https://phorge.dev.yugabyte.com/D37947
es1024 added a commit that referenced this issue Sep 11, 2024
@es1024
[BACKPORT 2024.1][#23841] docdb: Disable stack trace tracking in TSAN…
285bda0 
… builds

Summary:
Original commit: e86951a / D37947
Stack trace tracking adds a performance penalty causing various tests to fail in TSAN
builds. This diff disables stack trace tracking in TSAN builds.
Jira: DB-12745

Test Plan: Jenkins: build type: tsan, cpp only

Reviewers: bkolagani

Reviewed By: bkolagani

Subscribers: ybase

Differential Revision: https://phorge.dev.yugabyte.com/D37958
jasonyb pushed a commit that referenced this issue Sep 12, 2024
@yugabyte-ci @jaki
[BACKPORT pg15-cherrypicks] all: Bulk port from master - 98
c368a58 
Summary:
 f5ad1fb [#23855] Fixing the calculation of automatic refactoring count.
 eed826d [#22519] YSQL: Move ExplicitRowLockBuffer class into separate file
 99a27e6 [PLAT-14522] Taking yba-ctl backups with prometheus HTTPS
 e2a84b0 [PLAT-15044] Add preflight check for node addition in provider
 7e40d89 [#20769] XCluster: Dynamically apply cdc_wal_retention_time_secs for XCluster
 aa41478 [#23858] build: fix ./yb_build.sh release --gcc11
 bcf7f47 [PLAT-13910] Improve IAM credentials fetch logging and add retries
 303a202 [#23778] xCluster: Remove the capability to rename xCluster replication groups
 Excluded: 58fd26e [#23652] YSQL: Fix TestPgRegressAnalyze.java timeout / database drop failure on TSAN build
 31da65b [doc] yb_enable_bitmapscan flag (#23854)
 798db14 [#20335] DocDB: Use MonoClock for write query metric
 80779d8 [#23860] xCluster: Add automatic ddl mode proto fields
 afd763d Revert "Revert "[PLAT-14786] Add support to node_agent install to use bind ip and node_external_fqdn""
 e86951a [#23841] docdb: Disable stack trace tracking in TSAN builds
 d600608 [PLAT-15244] Fix schedule not getting updated on edit schedule API call
 3c0df09 [PLAT-15214][PLAT-15232]YBC version upgrade to 2.2.0.0-b6 and enable YBC verbose by default
 aa7372e [#23478] YSQL: fix connection manager session variable case sensitivity issue
 0d53558 [PLAT-14810][PLAT-14811][YBA CLI] Support adding and editing EIT configurations
 ffa537e [PLAT-10706][dr] Support retry-ability of failover and switchover
 Excluded: 5ae4558 [#23578] YSQL: Add HELP and TYPE to :13000/prometheus-metrics
 3aa7459 [PLAT-15016] Handle gflag_group changes for ENHANCED_PG_COMPATIBILITY group in 2024.1.3
 c89356c [PLAT-10592][YBA] Changes to support global tserver/master service in K8s
 7fc3b76 [#3893] YCQL: Align 2 system_schema.* tables with Cassandra
 da6274e [23646] Test Stability: Fix PgMiniTest.FollowerReads
 5fa6dc9 [PLAT-15180][Platform][UI][PITR]Create Restore Backup modal
 be0d1d1 [PLAT-15247][Platform][Backup]Create Backup scheduled policy List

Test Plan: Jenkins: rebase: pg15-cherrypicks

Reviewers: jason, tfoucher

Subscribers: yql

Differential Revision: https://phorge.dev.yugabyte.com/D37981
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@es1024 es1024

Labels
2024.1 Backport Required area/docdb YugabyteDB core features kind/bug This issue is a bug priority/medium Medium priority issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@es1024 @rthallamko3 @yugabyte-ci @basavaraj29