Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MetricsTest.SimpleLagTest broken in non-macOS builds #5081

Closed
hectorgcr opened this issue Jul 14, 2020 · 0 comments
Closed

MetricsTest.SimpleLagTest broken in non-macOS builds #5081

hectorgcr opened this issue Jul 14, 2020 · 0 comments
Assignees
@hectorgcr
Labels
kind/failing-test Tests and testing infra

Comments

@hectorgcr
Copy link
Contributor

hectorgcr commented Jul 14, 2020 •
edited by daniel-yb
Loading

MetricsTest.SimpleLagTest broken in non-macOS builds
@hectorgcr hectorgcr added the kind/failing-test Tests and testing infra label Jul 14, 2020
@hectorgcr hectorgcr self-assigned this Jul 14, 2020
hectorgcr added a commit that referenced this issue Aug 4, 2020
@hectorgcr
#5081: Fix MetricsTest.SimpleLagTest
4c0a2fe 
Summary:
Fix MetricsTest.SimpleLagTest in non macOS builds.

Setting the internal timestamp to the time the metric
was created.

Test Plan:
Ran SimpleLagTest and SimpleAtomicLagTest
ybd asan --cxx-test ql_ql-create-table-test --gtest_filter TestQLCreateTable.TestMetrics -n 100

Reviewers: mikhail, sergei

Reviewed By: sergei

Subscribers: bogdan, ybase

Differential Revision: https://phabricator.dev.yugabyte.com/D8904
hectorgcr added a commit that referenced this issue Sep 5, 2020
@hectorgcr
#5359: Revert "#5081: Fix MetricsTest.SimpleLagTest"
ecf9a28 
Summary:
This reverts commit 4c0a2fe.

There is currently an issue with the new clock introduced with this diff that causes a crash in some scenarios when the metric is queried.
```#0  Now (this=0x742f680192a46a02) at ../../src/yb/common/clock.h:27
#1  lag_ms (this=0x5dadc40) at ../../src/yb/util/metrics.h:1355
#2  yb::AtomicMillisLag::WriteForPrometheus (this=0x5dadc40, writer=0x7fbdc2f84bb0, attr=..., opts=...) at ../../src/yb/util/metrics.h:1374
#3  0x00007fbdedc2ab83 in yb::MetricEntity::WriteForPrometheus (this=<optimized out>, writer=writer@entry=0x7fbdc2f84bb0, opts=...) at ../../src/yb/util/metrics.cc:351
#4  0x00007fbdedc2cf05 in yb::MetricRegistry::WriteForPrometheus (this=this@entry=0x1a70a80, writer=writer@entry=0x7fbdc2f84bb0, opts=...) at ../../src/yb/util/metrics.cc:491
#5  0x00007fbdf2cfe6d0 in yb::(anonymous namespace)::WriteForPrometheus (metrics=0x1a70a80, req=..., resp=0x7fbdc2f84de0) at ../../src/yb/server/default-path-handlers.cc:278
#6  0x00007fbdf2d2d95c in operator() (__args#1=0x7fbdc2f84de0, __args#0=..., this=<optimized out>)
    at /home/yugabyte/yb-software/yugabyte-2.3.0.0-b88-centos-x86_64/linuxbrew-xxxxxxxxxxxxx/Cellar/gcc/5.5.0_4/include/c++/5.5.0/functional:2267
#7  yb::Webserver::RunPathHandler (this=this@entry=0x1d64000, handler=..., connection=connection@entry=0x7d88000, request_info=request_info@entry=0x7d88000) at ../../src/yb/server/webserver.cc:423
#8  0x00007fbdf2d2e5ea in yb::Webserver::BeginRequestCallback (this=0x1d64000, connection=0x7d88000, request_info=0x7d88000) at ../../src/yb/server/webserver.cc:360
#9  0x00007fbdf2d438f6 in handle_request () from /home/yugabyte/yb-software/yugabyte-2.3.0.0-b88-centos-x86_64/lib/yb/libserver_process.so
#10 0x00007fbdf2d464de in worker_thread () from /home/yugabyte/yb-software/yugabyte-2.3.0.0-b88-centos-x86_64/lib/yb/libserver_process.so
#11 0x00007fbde84c5694 in start_thread (arg=0x7fbdc2f8f700) at pthread_create.c:333
#12 0x00007fbde7c0241d in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:109```

Test Plan: Build and unit tests

Reviewers: bogdan, amitanand, kannan

Reviewed By: kannan

Subscribers: kannan, ybase

Differential Revision: https://phabricator.dev.yugabyte.com/D9322
hulien22 added a commit that referenced this issue Sep 23, 2020
@hulien22
[docdb] Initialize timestamp_ms_ for MillisLag (#5081, #5762)
e5494f1 
Summary:
Before we were not initializing `timestamp_ms_` which caused flaky errors for `MetricsTest.SimpleLagTest` - changing this to now initialize to `now`.
Also fixing ASAN issue in `MetricsTest::DoLagTest`

Test Plan:
```
ybd --cxx-test util_metrics-test --gtest_filter MetricsTest.SimpleLagTest -n 100
ybd --cxx-test util_metrics-test --gtest_filter MetricsTest.SimpleAtomicLagTest -n 100
```

Reviewers: hector

Reviewed By: hector

Subscribers: bogdan, ybase

Differential Revision: https://phabricator.dev.yugabyte.com/D9431
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hectorgcr hectorgcr

Labels
kind/failing-test Tests and testing infra
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hectorgcr