Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to using smart driver for yb-pgsql unit tests #9788

Closed
kneeraj opened this issue Aug 20, 2021 · 1 comment
Closed

Switch to using smart driver for yb-pgsql unit tests #9788

kneeraj opened this issue Aug 20, 2021 · 1 comment
Assignees
@kneeraj
Labels
area/ecosystem Label for all ecosystem related projects

Comments

@kneeraj
Copy link
Contributor

kneeraj commented Aug 20, 2021

The ysql unit tests, 'yb-pgsql' tests use the standard postgres jdbc driver for running the unit tests. It should be changed to use the new YugabyteDB smart driver which is an enhancement over the standard postgres jdbc client driver.
@kneeraj kneeraj added the area/ecosystem Label for all ecosystem related projects label Aug 20, 2021
@kneeraj kneeraj self-assigned this Aug 20, 2021
kneeraj added a commit that referenced this issue Oct 26, 2021
@kneeraj
[#9788] YSQL SMARTDRIVER: Switch to using smart driver for yb-pgsql u…
d9b0de9 
…nit tests

Summary:
Currently the yb-pgsql test uses the upstream PostgreSQL driver version 42.2.5. Changing it to use the latest 'beta' version of the jdbc-yugabytedb version which is 42.3.0-beta.1. The mvn dependency is:

```
<dependency>
      <groupId>com.yugabyte</groupId>
      <artifactId>jdbc-yugabytedb</artifactId>
      <version>42.3.0-beta.1</version>
    </dependency>
```

Please note the upstream version is pgjdbc 42.3.0.

Additionally the unit tests for load balance has been augmented to test whether the load is close to evenly distributed when multiple connections are being created concurrently.
This test also uses the exact port of servers for connectivity rather than hard code value of '5433' used earlier. This is corresponding to the change done in commit revision c4308a8

Test Plan:
The testLoadBalance unit test is augmented to take care of the above mentioned changes.
The entire unit test was run locally against the new version and they ran fine.

Reviewers: zyu, mihnea

Reviewed By: zyu, mihnea

Subscribers: yql

Differential Revision: https://phabricator.dev.yugabyte.com/D12689
@kneeraj
Copy link
Contributor Author

kneeraj commented Dec 21, 2021

It is done in rd9b0de9665eea2b64b88a87826a9f3ed03a10b77

@kneeraj kneeraj closed this as completed Dec 21, 2021
This was referenced Nov 8, 2022
Open
Open
@nyndyny nyndyny mentioned this issue Jan 1, 2023
Open
@snyk-bot snyk-bot mentioned this issue Jan 2, 2023
Open
@nyndyny nyndyny mentioned this issue Jun 23, 2023
Open
@ryan-ally ryan-ally mentioned this issue Jun 24, 2023
Open
@nyndyny nyndyny mentioned this issue Jun 30, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kneeraj kneeraj

Labels
area/ecosystem Label for all ecosystem related projects
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kneeraj