Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] SSL/TLS configuration with hashicorp vault YSQL plugin #23979

Merged
merged 7 commits into from
Sep 18, 2024

Conversation

HarshDaryani896
Copy link
Contributor

Updating hashicorp vault YSQL plugin docs to add steps to configure SSL/TLS connectivity.

@HarshDaryani896 HarshDaryani896 changed the title [DOCS] SSL/TLS configuration with hashicorp vault YSQL plugin [docs] SSL/TLS configuration with hashicorp vault YSQL plugin Sep 17, 2024
Copy link

netlify bot commented Sep 17, 2024

Deploy Preview for infallible-bardeen-164bc9 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 171c3a7
🔍 Latest deploy log https://app.netlify.com/sites/infallible-bardeen-164bc9/deploys/66eafa6859368d0008f8e43a
😎 Deploy Preview https://deploy-preview-23979--infallible-bardeen-164bc9.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@kneeraj kneeraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just 1 comment. Please have a look. Rest looks good.

docs/content/preview/integrations/hashicorp-vault.md Outdated Show resolved Hide resolved
Copy link
Contributor

@kneeraj kneeraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Collaborator

@aishwarya24 aishwarya24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with minor suggestions. Please commit them and merge. Thanks @HarshDaryani896

docs/content/preview/integrations/hashicorp-vault.md Outdated Show resolved Hide resolved
docs/content/preview/integrations/hashicorp-vault.md Outdated Show resolved Hide resolved
docs/content/preview/integrations/hashicorp-vault.md Outdated Show resolved Hide resolved
docs/content/preview/integrations/hashicorp-vault.md Outdated Show resolved Hide resolved
docs/content/preview/integrations/hashicorp-vault.md Outdated Show resolved Hide resolved
docs/content/preview/integrations/hashicorp-vault.md Outdated Show resolved Hide resolved
docs/content/preview/integrations/hashicorp-vault.md Outdated Show resolved Hide resolved
@HarshDaryani896 HarshDaryani896 merged commit c8776b5 into yugabyte:master Sep 18, 2024
2 checks passed
@HarshDaryani896 HarshDaryani896 deleted the hashicorp-vault-doc branch September 18, 2024 16:14
foucher added a commit that referenced this pull request Sep 20, 2024
Summary:
 6b34652 [doc] Update badge colors (#23985)
 6dcfce6 [PLAT-15297][dr] GET /configs fails with java.lang.IllegalStateException: DrConfig iTest-dr(uuid) does not have any corresponding xCluster config
 7995311 [#23695] docdb: Improve help strings for tablet replica limit flags.
 7659151 [DOC-479] Voyager 1.8.1 updates (#23983)
 56c9cc9 [PLAT-15282]: fix NPE on k8s operator backup/restore status update
 c8776b5 [docs] SSL/TLS configuration with hashicorp vault YSQL plugin (#23979)
 Excluded: d3dd4f7 Bumping version to 2.25.0.0 on branch master
 Excluded: 0dbe7d6 [#23312] YSQL: Fix backup/restore for colocated tables without tablespace information.
 2beb872 [#23786] YSQL: add yb_make_next_ddl_statement_nonincrementing to YbDbAdminVariables
 28d0d8e [#24011] build: fix ./yb_build.sh --gcc13
 9feb6e8 [#24012] YSQL: Replace deprecated function shared_ptr::unique to fix macos compiler error
 2cc1480 [PLAT-15349] Fix update_lb_config automated NLB updates
 af4c46d [#23741] docdb: Add parameter to run PITR tests with clone instead
 0103dfc [PLAT-14459] Continuous backups for s3
 e6bb890 [PLAT-15192] [PLAT-15191] Document node-agent-provision.yaml
 1552321 [PLAT-15205] YBA callhome improvements
 ba6acbd [PLAT-15342] Install Node Agent as root level unit for ynp
 2478a50 [PLAT-13058] Remove references to public key filepath, since we don't need ssh keys for node agent based provisioning
 aa14f76 [#23975] YSQL, ASH: Fix TestYbAsh#testPgAuxInfo
 885b72b [#23960] DocDB: Fix WriteBuffer crash in move ctor
 Excluded: f4a002a [#23314] YSQL: Fix variable name to yb_ for ATPrepSetTableSpace
 29c56ed [PLAT-15369][YBA CLI]Backup list-increments doesn't support pretty/json outputs
 784160c [PLAT-15370][YBA CLI]backup list table output contains base_backup_uuid and backup_uuid
 b32222d [PLAT-15280][PLAT-14753] - Pg parity improvements and other ui fixes
 c6521cf [PLAT-15368][YBA CLI]Backup list print "No more backup present" after printing all the backups in -o pretty/json

- pg_catalog_version-test.cc
   - NonIncrementingDDLMode: YB master commit 2beb872 sets the role to yb_db_admin, which due to new behavior in upstream PG commit b073c3ccd06e4cb845e121387a43faa8c68a7b62 (documented in https://www.postgresql.org/docs/15/ddl-schemas.html#DDL-SCHEMAS-PATTERNS) causes the following unintended test failure: ERROR:  permission denied for schema public. Add a workaround to grant create permission to the role now set.

Test Plan: Jenkins: urgent, rebase: pg15-cherrypicks

Reviewers: jason, jenkins-bot

Differential Revision: https://phorge.dev.yugabyte.com/D38220
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants