Merge pull request #78 from yushiang-demo/fix-viewer-runtime-error

fix-viewer-runtime-error
yushiang-demo · Mar 5, 2024 · 8ae6ead · 8ae6ead
2 parents d45dab8 + f1b71ef
commit 8ae6ead
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -11,6 +11,8 @@ The format is based on [Keep a Changelog](https://github.com/olivierlacan/keep-a
 
 ### Fixed
 
+- Fix `decoration`, `viewer` pages runtime error. (https://github.com/yushiang-demo/pano-to-mesh/pull/78)
+
 ### Removed
 
 ## [2.1.1] - 2024-03-05

diff --git a/apps/editors/decoration/index.js b/apps/editors/decoration/index.js
@@ -120,7 +120,7 @@ const Editor = ({ data }) => {
   }, []);
 
   useEffect(() => {
-    threeRef.current.cameraControls.setEnable(mode === MODE.SELECT);
+    threeRef.current?.cameraControls.setEnable(mode === MODE.SELECT);
   }, [mode]);
 
   const focusedMedia = media[focusedIndex];
@@ -153,6 +153,8 @@ const Editor = ({ data }) => {
     [focusedIndex]
   );
 
+  if (!panorama) return null;
+
   return (
     <>
       <ThreeCanvas dev={dev} ref={threeRef} {...eventHandlers}>

diff --git a/apps/viewer.js b/apps/viewer.js
@@ -114,6 +114,8 @@ const Viewer = ({ data }) => {
     );
   });
 
+  if (!panorama) return null;
+
   return (
     <>
       <ThreeCanvas dev={dev} ref={threeRef} {...eventsHandlers}>