Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail-Policy set wrong when protocol is not specified #193

Closed
kriloleg opened this issue Dec 21, 2018 · 1 comment
Closed

Fail-Policy set wrong when protocol is not specified #193

kriloleg opened this issue Dec 21, 2018 · 1 comment
Assignees
Labels
Milestone

Comments

@kriloleg
Copy link

Hi guys.

Faced the issue, that when try to use SRV discovery type and omit srv_dns_protocol, that should be set to default value according to the documentation there will be messed result when getting service statistic.
Here are the steps to reproduce:

  1. Set discovery configuration, omiting dns_protocol
[servers.server.discovery]
failpolicy = "keeplast"
kind = "srv"
srv_lookup_server = "192.20.54.73:53"
srv_lookup_pattern = "server-dev.marathon.mesos."
  1. Query statistic with API

curl http://localhost:8888/servers/server

  1. Check response field 'failpolicy'. It sets to the 'tcp' value that is not correct
 "discovery": {
        "kind": "srv",
        "failpolicy": "tcp",
        "interval": "0",
        "timeout": "0",
        "srv_lookup_server": "192.20.54.73:53",
        "srv_lookup_pattern": "_server-dev._tcp.marathon.mesos.",
        "srv_dns_protocol": ""
 }

Best regards

@yyyar yyyar added the bug label Dec 21, 2018
@yyyar yyyar self-assigned this Dec 21, 2018
@yyyar yyyar added this to the 0.7.0 milestone Dec 21, 2018
@yyyar
Copy link
Owner

yyyar commented Dec 23, 2018

Fixed

@yyyar yyyar closed this as completed Dec 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants