Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support gatsbyjs-v3 #51

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

tonitrnel
Copy link

mainly modify the issuer property.

documentation on Webpack5 issuer property.
https://webpack.js.org/configuration/module/#ruleissuer

@coreyward
Copy link
Collaborator

Thanks for jumping on this! Is there a way to maintain support for pre-3.0 Gatsby with the same codebase?

@tonitrnel
Copy link
Author

The versions of other GatsbyJS plugin packages have been upgraded from 2.x.x to 3.x.x, I think changing the package version number to 3.x.x can clearly indicate support for GatsbyJS V3

@kaishin
Copy link

kaishin commented Mar 3, 2021

Came looking for this. Great work @piecego!

@coreyward
Copy link
Collaborator

I've published this as v3.0.0-beta.0 for the time being so anybody on Gatsby v3 can give this a whirl without blocking on a solution that will allow us to maintain compatibility with Gatsby v2. This is something that I'd consider a very high priority since v2 has been out in the wild for over 2 years and likely has millions of installs, and the tendency with JS packages is to simply yarn add x instead of specifying a particular version range per-package, especially for plumbing like gatsby-plugin-svgr.

@tonitrnel tonitrnel closed this Mar 5, 2021
@coreyward
Copy link
Collaborator

Hey @piecego, I'm going to re-open this since it hasn't been merged in yet. 😄

package.json Outdated Show resolved Hide resolved
Co-authored-by: Lennart <lekoarts@gmail.com>
@K20shores
Copy link

Will this be merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants