chore: fixing OMP issues for macOS ARM and Python3.11. #870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
bcm-at-zama
commented
Sep 11, 2024
bcm-at-zama
commented
- Looks like the OMP issues also happen on ARM
- And by the way, we didn't have the fix for Python3.11
bcm-at-zama
commented
Sep 11, 2024
| @@ -10,7 +10,7 @@ MACHINE=$(uname -m) | |||
| PYTHON_VERSION=$(python --version | cut -d' ' -f2 | cut -d'.' -f1,2) | |||
| DO_REGENERATE=0 | |||
|
|
|||
| if [ "$UNAME" == "Darwin" ] && [ "$MACHINE" != "arm64" ] | |||
There was a problem hiding this comment.
I don't know how it works for you, @fd0r @RomanBredehoft
Could you tell me?
There was a problem hiding this comment.
I'm getting an error when running make sybc_env
bcm-at-zama
commented
Sep 11, 2024
| elif [ "$PYTHON_VERSION" == "3.11" ] | ||
| then | ||
| rm "${WHICH_VENV}"/lib/"${WHICH_PYTHON}"/./site-packages/xgboost/.dylibs/libomp.dylib | ||
| ln -s "${WHICH_VENV}"/lib/"${WHICH_PYTHON}"/site-packages/concrete/.dylibs/libomp.dylib "${WHICH_VENV}"/lib/"${WHICH_PYTHON}"/./site-packages/xgboost/.dylibs/libomp.dylib |
There was a problem hiding this comment.
completely trivial to add now, thanks to the DO_REGENERATE=1 option!
we'll be able to add 3.12 easily
bcm-at-zama
force-pushed
the
fix_omp_mac_arm_and_python311
branch
from
dac8529
to
19b30c8
Compare
bcm-at-zama
commented
Sep 11, 2024
| echo "Please have a look to libraries libiomp5.dylib related to torch and then" | ||
| echo "apply appropriate fix" | ||
| exit 255 | ||
| # The error is specific to python version |
There was a problem hiding this comment.
So finally I haven't changed the things for Intel, and I have created a new category for ARM, where all python are equivalent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.