Merge pull request #3 from martinmaillard/error-handling

Avoid swallowing errors from FTP client
zazuko · Sep 23, 2019 · 548e706 · 548e706
2 parents 7ffa9db + 6426151
commit 548e706
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/packages/ftp/lib/command.js b/packages/ftp/lib/command.js
@@ -13,7 +13,8 @@ async function command (options, callback, keepAlive = false) {
 
     return result
   } catch (err) {
-    return client.disconnect()
+    await client.disconnect()
+    throw err
   }
 }
 

diff --git a/packages/ftp/test/list.test.js b/packages/ftp/test/list.test.js
@@ -32,4 +32,15 @@ describe('list', () => {
 
     expect(filenames).toEqual(['data/abc.txt', 'data/xyz.txt'])
   })
+
+  it('throws proper error when file does not exist', async () => {
+    const server = new FtpServer()
+    await server.start()
+
+    await expect(list({ pathname: 'does-not-exist', ...server.options }))
+      .rejects
+      .toThrow('no such file or directory')
+
+    await server.stop()
+  })
 })