fix: missing code to wire-up file loader #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 0ec28c1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report
@@ Coverage Diff @@
## master #145 +/- ##
==========================================
- Coverage 90.92% 90.77% -0.15%
==========================================
Files 78 79 +1
Lines 3130 3155 +25
==========================================
+ Hits 2846 2864 +18
- Misses 284 291 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
Some tests failed for |
|
Working on it but I don't understand what happened. Seems like unrelated tests start failing 🙄 |
…file-loader-missing-tests
ludovicm67
reviewed
Aug 2, 2023
ludovicm67
reviewed
Aug 2, 2023
Co-authored-by: Ludovic Muller <ludovicm67@users.noreply.github.com>
Co-authored-by: Ludovic Muller <ludovicm67@users.noreply.github.com>
ludovicm67
approved these changes
Aug 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #142 I forgot to add code which actually sets up the new loader in registry
Here, I did that and added an e2e test which uses the loader