Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(formats): type declarations #298

Merged
merged 6 commits into from
May 16, 2024
Merged

build(formats): type declarations #298

merged 6 commits into from
May 16, 2024

Conversation

Copy link

changeset-bot bot commented May 14, 2024

🦋 Changeset detected

Latest commit: 4f2552a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
barnard59-formats Patch
barnard59-env Patch
barnard59 Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Base automatically changed from parse-factory to master May 14, 2024 16:39
Copy link

codecov bot commented May 16, 2024

Codecov Report

Attention: Patch coverage is 26.13636% with 65 lines in your changes are missing coverage. Please review.

Project coverage is 84.69%. Comparing base (2c9e4e4) to head (4f2552a).

Files Patch % Lines
packages/formats/csvw.js 0.00% 29 Missing ⚠️
packages/formats/xlsx.js 0.00% 27 Missing ⚠️
packages/formats/lib/stream.js 0.00% 8 Missing ⚠️
packages/formats/jsonld.js 94.11% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #298      +/-   ##
==========================================
- Coverage   85.40%   84.69%   -0.72%     
==========================================
  Files         173      173              
  Lines        6866     6945      +79     
  Branches      102      102              
==========================================
+ Hits         5864     5882      +18     
- Misses       1000     1061      +61     
  Partials        2        2              
Flag Coverage Δ
barnard59 81.31% <ø> (ø)
barnard59-base 48.85% <ø> (ø)
barnard59-core 90.92% <ø> (ø)
barnard59-csvw 80.21% <ø> (ø)
barnard59-cube 96.39% <ø> (ø)
barnard59-formats 29.92% <26.13%> (-2.90%) ⬇️
barnard59-ftp 97.60% <ø> (ø)
barnard59-graph-store 95.10% <ø> (ø)
barnard59-http 87.50% <ø> (ø)
barnard59-rdf 94.84% <ø> (ø)
barnard59-s3 100.00% <ø> (ø)
barnard59-shacl 51.96% <ø> (ø)
barnard59-sparql 94.93% <ø> (ø)
barnard59-validation 97.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tpluscode tpluscode requested a review from ludovicm67 May 16, 2024 07:42
@tpluscode
Copy link
Contributor Author

@ludovicm67 what did we do last time when windows installation failed like that?

@ludovicm67
Copy link
Member

@ludovicm67 what did we do last time when windows installation failed like that?

The issue is coming from the approvals module, which seems to be broken since recent Node versions, as they updated the behavior of the spawn module.

We need to wait for this to be merged: approvals/Approvals.NodeJS#177
As it's the proper fix for it.

@tpluscode
Copy link
Contributor Author

Thanks. I applied here what we did in zazuko/cube-link#176

@tpluscode tpluscode merged commit d527713 into master May 16, 2024
36 of 38 checks passed
@tpluscode tpluscode deleted the formats-types branch May 16, 2024 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants