Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(csvw): types #309

Merged
merged 1 commit into from
Jun 13, 2024
Merged

feat(csvw): types #309

merged 1 commit into from
Jun 13, 2024

Conversation

tpluscode
Copy link
Contributor

Unlike most other packages, I actually changed the source to TS because I had trouble annotating the types just right. You'll see that mostly in lib/fetchMetadata.ts

Copy link

changeset-bot bot commented Jun 12, 2024

🦋 Changeset detected

Latest commit: b4936e9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
barnard59-csvw Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Jun 12, 2024

Codecov Report

Attention: Patch coverage is 87.27273% with 7 lines in your changes missing coverage. Please review.

Project coverage is 84.48%. Comparing base (bee1ca9) to head (b4936e9).

Files Patch % Lines
packages/csvw/filter.ts 0.00% 4 Missing ⚠️
packages/csvw/lib/fetchMetadata.ts 87.50% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #309      +/-   ##
==========================================
- Coverage   84.52%   84.48%   -0.04%     
==========================================
  Files         173      173              
  Lines        6977     6987      +10     
  Branches      102      112      +10     
==========================================
+ Hits         5897     5903       +6     
- Misses       1078     1082       +4     
  Partials        2        2              
Flag Coverage Δ
barnard59 81.31% <ø> (ø)
barnard59-core 90.92% <ø> (ø)
barnard59-csvw 78.21% <87.27%> (-2.01%) ⬇️
barnard59-cube 96.46% <ø> (ø)
barnard59-formats 28.17% <ø> (ø)
barnard59-ftp 97.60% <ø> (ø)
barnard59-graph-store 95.10% <ø> (ø)
barnard59-http 87.50% <ø> (ø)
barnard59-rdf 94.84% <ø> (ø)
barnard59-s3 100.00% <ø> (ø)
barnard59-shacl 51.96% <ø> (ø)
barnard59-sparql 94.93% <ø> (ø)
barnard59-validation 97.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tpluscode tpluscode merged commit 5867c79 into master Jun 13, 2024
39 checks passed
@tpluscode tpluscode deleted the csvw-ts branch June 13, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants