feat(shacl): validate command: look for shapes in validated chunk #322
Conversation
🦋 Changeset detectedLatest commit: b4b70c1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #322 +/- ##
==========================================
+ Coverage 84.34% 85.30% +0.96%
==========================================
Files 176 177 +1
Lines 7390 7411 +21
Branches 241 241
==========================================
+ Hits 6233 6322 +89
+ Misses 1155 1087 -68
Partials 2 2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| @@ -19,8 +20,7 @@ async function * validate(ds, maxViolations, iterable) { | |||
| break | |||
| } | |||
|
|
|||
| // create a new validator instance at each iteration to avoid memory leaks | |||
| const validator = new SHACLValidator(ds, { maxErrors: 0, factory: this.env }) | |||
| const validator = new SHACLValidator(shapes || chunk, { maxErrors: 0, factory: this.env }) | |||
There was a problem hiding this comment.
wondering about merging shapes and chunk, but probably not worth it for the overhead and the added complexity
There was a problem hiding this comment.
regular graph merge, hence collecting shapes from both
I wanted to be able to validate from the CLI command without
--shapes. In this case, the standard input would be expected to include the shapes tooAs consequence, in any pipeline where we use the SHACL step, we can process each chunk individually, where each can have different shapes too.