-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
logging to console (behind flag) #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bergos
reviewed
Jan 9, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you move bin/TextLogStream.js
to lib/TextLogStream.js
? There are no clear rules for the folder structure, but I think usually only the code which is used in the bin
property of package.json
is in the bin
folder.
bergos
approved these changes
Jan 9, 2019
tpluscode
pushed a commit
that referenced
this pull request
Jun 15, 2023
feat: added buildCubeShape operation
tpluscode
pushed a commit
that referenced
this pull request
Jul 24, 2023
use sparql-http-client + added get operation
tpluscode
pushed a commit
that referenced
this pull request
Aug 1, 2023
docs: document package operations in README
tpluscode
pushed a commit
that referenced
this pull request
Aug 31, 2023
fix: only step doesn't need to be readable or writable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7
@bergos, I added a simple stream which pushes log strings for events with a name. That should be enough for us for now.
Do you have anything else in mind?