Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update validation to current state #185

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Rdataflow
Copy link
Contributor

No description provided.

Copy link

changeset-bot bot commented Apr 19, 2024

⚠️ No Changeset found

Latest commit: ce8e63e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Rdataflow
Copy link
Contributor Author

@giacomociti would it make sense to update and simplify the validation steps - WDYT? - I like two step validation as you mention it in the docs (and the rest is done by the magic of profiles)
... so I wonder: might it be worth to mention them here?

@giacomociti
Copy link
Contributor

I approved the PR, your changes make sense to me @Rdataflow. But I'm not sure I get what you mean with updating the validation steps

@Rdataflow
Copy link
Contributor Author

Rdataflow commented Apr 22, 2024

@giacomociti the validation steps currently in this spec

  • The cube structure and contents
  • The structure of the observations
  • The integrity of the constraints

... while in the barnard59 cube docs there occur only two (because recently validation was simplified using the newly established code:imports functionality)

  • check-metadata
  • check-observations

therefore my question is whether it makes sense to you to adapt the validation steps validation of this spec to match those two from barnard59 documentation?

ps: this might be by summarizing point 1 and 3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants