Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Suggestion/Discussion] Support poetry #42

Merged
merged 2 commits into from
Sep 13, 2021
Merged

[Suggestion/Discussion] Support poetry #42

merged 2 commits into from
Sep 13, 2021

Conversation

dannywillems
Copy link
Contributor

@dannywillems dannywillems commented Jul 15, 2021 •
edited by str4d
Loading

Ease the installation and the environment setup for the different scripts.

Example:

poetry install
poetry run python orchard_poseidon.py

See the poetry website for more information.

@dannywillems dannywillems changed the title Support poetry [Suggestion/Discussion] Support poetry Jul 15, 2021
str4d
str4d approved these changes Sep 13, 2021
View reviewed changes
Copy link
Contributor

@str4d str4d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, it's like cargo for Python!

pyproject.toml Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
str4d
str4d reviewed Sep 13, 2021
View reviewed changes
pyproject.toml Show resolved Hide resolved
@str4d str4d added this to the Core Sprint 2021-34 milestone Sep 13, 2021
@str4d str4d merged commit 05a7a97 into zcash:master Sep 13, 2021
@dannywillems dannywillems deleted the add-poetry branch September 13, 2021 15:13
daira
daira reviewed Sep 14, 2021
View reviewed changes
Copy link
Contributor

@daira daira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Post-hoc ACK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daira daira daira left review comments

@str4d str4d str4d approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Core Sprint 2021-34
Development

Successfully merging this pull request may close these issues.
3 participants
@dannywillems @daira @str4d