fix: try to avoid segfaults in scanner.cc #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think the main change is checking for lexer->lookahead before doing lexer->get_column(lexer) since it was segfaulting in exactly that function.
theHamsta
commented
Apr 30, 2022
| } | ||
|
|
||
| if (lexer->get_column(lexer) == 0) { | ||
| if (lexer->lookahead && lexer->get_column(lexer) == 0) { |
There was a problem hiding this comment.
the python scanner had a while(lexer->lookahead) around everything
There was a problem hiding this comment.
Interesting... removing the lexer->lookahead part like that in your PR makes a lot of tests fail.
Putting it back in leads to segfault, so it's clear, that's the culprit.
Just opening a random vue with pug shows that the highlighting works at least, but the tests somehow show differences which I have to investigate.
There was a problem hiding this comment.
I changed more in this PR that just the lookahead. Maybe the reason why tests are failing are in other parts of this PR. I only tried to make the parser not SEGFAULT. I have no experience with pug or how this should be parsed
|
Fixes #2360 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think the main change is checking for lexer->lookahead before doing
lexer->get_column(lexer) since it was segfaulting in exactly that
function. Rest is just clang-format and call
deserialize(nullptr, 0)in the constructor.At least it's now not segfaulting anymore. I just checked on the fuzzer-side, not whether it is still fully functional. You would have to do that @zealot128 @RianFuro