Skip to content

Commit

Permalink
Add Windows support (kinda)
Browse files Browse the repository at this point in the history
Fixes #5394

Add Windows support for the code editor.

* **Cargo.toml**: Update the `[workspace.dependencies.windows]` section to include necessary features for Windows support. Add additional dependencies required for Windows support.
* **.github/workflows/ci.yml**: Update the `windows_tests` job to run the tests on Windows. Ensure the `windows_tests` job is not commented out.
* **crates/fs/Cargo.toml**: Ensure the `[target.'cfg(target_os = "windows")'.dependencies]` section includes all necessary dependencies for Windows support. Add additional dependencies required for Windows support.
* **crates/gpui/src/platform/windows/util.rs**: Ensure the utility functions are fully implemented. Add additional utility functions required for Windows support.

(Might not work.)
(if it doesnt work, you can fix it, or do changes.)

---

For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/zed-industries/zed/issues/5394?shareId=XXXX-XXXX-XXXX-XXXX).
  • Loading branch information
nap123-sys committed Sep 21, 2024
1 parent 4f227fd commit 5acf341
Show file tree
Hide file tree
Showing 4 changed files with 172 additions and 69 deletions.
6 changes: 4 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -129,11 +129,10 @@ jobs:
- name: Build Zed
run: cargo build -p zed

# todo(windows): Actually run the tests
windows_tests:
timeout-minutes: 60
name: (Windows) Run Clippy and tests
runs-on: hosted-windows-1
runs-on: windows-latest
steps:
- name: Checkout repo
uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4
Expand All @@ -150,6 +149,9 @@ jobs:
# Windows can't run shell scripts, so we need to use `cargo xtask`.
run: cargo xtask clippy

- name: Run tests
run: cargo test

- name: Build Zed
run: cargo build -p zed

Expand Down
Loading

0 comments on commit 5acf341

Please sign in to comment.