Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set the default DPI awareness for Zed #8936

Merged
merged 2 commits into from
Mar 6, 2024

Conversation

JunkuiZhang
Copy link
Contributor

@JunkuiZhang JunkuiZhang commented Mar 6, 2024

Description

This is a part of

Release Notes:

  • N/A

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Mar 6, 2024
@JunkuiZhang
Copy link
Contributor Author

By default, windows apps (win32 apps mainly) are unable to automatically handle DPI scaling. Without such work, applications will appear blurry.

Using the manifest file is the Microsoft recommanded way, and any app developed using gpui should follow this method, maybe we should doc it somewhere?

@JunkuiZhang JunkuiZhang changed the title Setting the default DPI awareness for Zed Set the default DPI awareness for Zed Mar 6, 2024
@mikayla-maki mikayla-maki self-assigned this Mar 6, 2024
@mikayla-maki mikayla-maki requested review from kvark and removed request for kvark March 6, 2024 19:38
@mikayla-maki mikayla-maki merged commit 8357039 into zed-industries:main Mar 6, 2024
7 checks passed
@mikayla-maki
Copy link
Contributor

Using the manifest file is the Microsoft recommanded way, and any app developed using gpui should follow this method, maybe we should doc it somewhere?

When GPUI is more developed, we should add these kinds of bundling requirements into gpui.rs, or our own bundling tool. But for now, this should be fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed The user has signed the Contributor License Agreement windows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants