-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make extrinsics #[transactional]
#576
Conversation
69c4c3a
to
016c208
Compare
|
I get the following error:
|
37e9c21
to
cde754a
Compare
I'm going through with the workaround. The issue is #608. |
A minimization of the compiler bug is reported in rust-lang/rust#96299. |
beac448
to
58a6364
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: Harald Heckmann <mail@haraldheckmann.de>
8a8af05
to
bdfc5c5
Compare
We make all extrinsics
#[transactional]
unless they are not already explicitly marked as non-transactional. We now useMARK(non-transactional): description...
as format for marking extrinsics which use verify-first-write-second.Fixes zeitgeistpm/runtime-audit-1#17, fixes zeitgeistpm/runtime-audit-1#18, fixes zeitgeistpm/runtime-audit-1#24 and fixes zeitgeistpm/runtime-audit-2#7.