errors: Remove log::error in server
#1881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
har7an
force-pushed
the
errors/remove-log-error-in-server
branch
from
8543f5d
to
48d3ebc
Compare
har7an
force-pushed
the
errors/remove-log-error-in-server
branch
from
48d3ebc
to
a68a83f
Compare
har7an
added a commit
to har7an/zellij
that referenced
this pull request
Nov 2, 2022
with better error logging by means of `non_fatal`. This preserves the original error and allows adding context information on top. Also makes error formatting more uniform across the application.
with better error logging by means of `non_fatal`. This preserves the original error and allows adding context information on top. Also makes error formatting more uniform across the application.
and propagate the error to the caller instead.
with better error logging by means of `non_fatal`. This preserves the original error and allows adding context information on top. Also makes error formatting more uniform across the application. Also add per-instruction error context to make it clear what we tried to accomplish when an error occured.
and sort them into a better order.
with better error logging by means of `non_fatal`. This preserves the original error and allows adding context information on top. Also makes error formatting more uniform across the application.
and sort them into a better order.
with better error logging by means of `non_fatal`. This preserves the original error and allows adding context information on top. Also makes error formatting more uniform across the application.
for terminals IDs that don't exist, instead of propagating the error to the user.
rather than providing a hard-coded error reason which is plain wrong in this context.
har7an
force-pushed
the
errors/remove-log-error-in-server
branch
from
d4a8d1c
to
de844f9
Compare
and change `get_active_tab(_mut)?` to return a `Result` instead of an `Option`. This already makes many places in the code obsolete where previously "failed to get active tab..." was logged manually. Rather than logging, use the `anyhow::Error`s we have, along with all their context information, and log these instead.
har7an
force-pushed
the
errors/remove-log-error-in-server
branch
from
de844f9
to
097194f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and replace it with variations of
Err....non_fatal()to preserve more information in the error log messages.