This repository has been archived by the owner on Jan 21, 2020. It is now read-only.
POST as JSON to the Twitter API #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All endpoints except for the various media upload endpoints can be sent as JSON; in fact, a few of the newer endpoints (`media/metadata/create`, `direct_messages/events/new`, and the `direct_messages/welcome_messages/*` endpoints) REQUIRE JSON payloads. This patch updates the `Twitter::performPost()` method to `json_encode()` non-string `$data`, inject the `$data` as the request body, and to emit as `Content-Type: application/json` always.
weierophinney
force-pushed
the
feature/json-requests
branch
from
478639f
to
4aa8d89
Compare
weierophinney
added a commit
that referenced
this pull request
Aug 15, 2017
weierophinney
added a commit
that referenced
this pull request
Aug 15, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All endpoints except for the various media upload endpoints can be sent as JSON; in fact, a few of the newer endpoints (
media/metadata/create,direct_messages/events/new, and thedirect_messages/welcome_messages/*endpoints) REQUIRE JSON payloads.This patch updates the
Twitter::performPost()method tojson_encode()non-string$data, inject the$dataas the request body, and to emit asContent-Type: application/jsonalways.This patch builds on #39 currently, and will be rebased once that patch is merged.