Drop zend loader, module loader and autoloader provider features. #78
Conversation
docs/book/migration/to-v3-0.md
Outdated
| ### Composer installed modules | ||
|
|
||
| For composer installed modules, autoloading rules will be automatically picked | ||
| by composer from the module's composer.json and no extra effort is needed:. |
There was a problem hiding this comment.
Remove . at the end of the line please.
| @@ -13,7 +13,7 @@ | |||
| use Zend\EventManager\EventManager; | |||
| use Zend\EventManager\SharedEventManager; | |||
| use Zend\ModuleManager\Listener\LocatorRegistrationListener; | |||
| use Zend\ModuleManager\Listener\ModuleResolverListener; | |||
| use Zend\ModuleManager\Listener\DefaultListenerAggregate; | |||
There was a problem hiding this comment.
Alphabetical order please.
There was a problem hiding this comment.
ugh, this is weird. I don't remember doing that change
docs/book/migration/to-v3-0.md
Outdated
| { | ||
| public function getAutoloaderConfig() | ||
| { | ||
| return array( |
There was a problem hiding this comment.
Lets use short array notation in that example
Xerkus
force-pushed
the
feature/drop-zend-loader
branch
2 times, most recently
from
5186cea
to
9873682
Compare
| @@ -0,0 +1,84 @@ | |||
| # Upgrading to 3.0 | |||
|
|
|||
| ## Module autoloading | |||
There was a problem hiding this comment.
The migration guide is very good, but only here the autoloading is included. No code example for autoloading in the other documents. Only a note in the introduction.
I think a code example (composer.json) in the module class chapter will help a lot.
michalbundyra
force-pushed
the
feature/drop-zend-loader
branch
from
9873682
to
0cd93ac
Compare
|
This repository has been closed and moved to laminas/laminas-modulemanager; a new issue has been opened at laminas/laminas-modulemanager#4. |
|
This repository has been moved to laminas/laminas-modulemanager. If you feel that this patch is still relevant, please re-open against that repository, and reference this issue. To re-open, we suggest the following workflow:
|
Composer has became a de-facto standard for managing dependencies and autoloading, Zend Framework itself distributes and manages its dependencies via composer. That makes Composer virtually guaranteed to be present for any application.
This PR drops autoloader support in zend-modulemanager in favor of composer autoloader.
This change opens a way for more Module Manager improvements to follow.