This repository has been archived by the owner on Feb 6, 2020. It is now read-only.
Use default values for type-hinted arguments if type not found in container #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tainer Per zendframework#239, currently when an argument is type-hinted but has a default value (typically `null`), the factory raises an exception about not being able to retrieve the value from the container. In such cases, we can use the default value for the argument during injection.
weierophinney
added a commit
that referenced
this pull request
Jan 29, 2018
weierophinney
added a commit
that referenced
this pull request
Jan 29, 2018
weierophinney
added a commit
that referenced
this pull request
Jan 29, 2018
Forward port #243 Conflicts: CHANGELOG.md
weierophinney
deleted the
hotfix/239-reflection-factory-default-values
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per #239, currently when an argument is type-hinted but has a default value (typically
null), the factory raises an exception about not being able to retrieve the value from the container. In such cases, we can use the default value for the argument during injection.Fixes #239.