This repository has been archived by the owner on Jan 31, 2020. It is now read-only.
fixed issue #8 with count increment on insert #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dankobiaka this requires a test case :-) |
|
complete |
|
@dankobiaka The PR conflicts with master. Could you please rebase your branch? |
|
I've tagged zend-stdlib 2.4.4, and will be back-porting this to an LTS release of ZF2 today. |
|
@weierophinney 2.5 should be released too |
|
@Maks3w after I get the LTS release done, that's the plan. |
|
Allow this fix to undo zendframework/zendframework#7446? |
|
@Maks3w No; they're separate issues. This one has to do with the count, while the other has to do with removal of items during iteration. They're not related. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added additional check to only increment count if item doesn't already exist.