Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added my duck #332

Merged
merged 4 commits into from
Oct 5, 2023
Merged

Added my duck #332

merged 4 commits into from
Oct 5, 2023

Conversation

ankushbhardwaj408
Copy link
Contributor

Description

Here my contribution to "The Duck Gallery".

You must respect the following conditions

  1. Your contribution must respect the code of conduct
  2. It's your first PR to this repository
  3. You have added your image of the duck downloaded from https://pimpmyduck.zenika.com
  4. You have not changed the image of the duck
  5. The image filename must be your GitHub username (ex: your-username.png)
  6. You are using your own GitHub user and it's the same as the PR author
  7. Into the contributors.js file, the message must be short and respect the code of conduct

If the PR doesn't respect those conditions, it will be closed

Copy link
Member

@jeanphi-baconnais jeanphi-baconnais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution !

@jeanphi-baconnais jeanphi-baconnais merged commit e6f4c4c into zenika-open-source:master Oct 5, 2023
1 of 2 checks passed
@arthurzenika
Copy link
Contributor

The image filename needs to be changed to ankushbhardwaj408.png

@arthurzenika
Copy link
Contributor

The netlify review app could have helped to catch the missing image !

@jeanphi-baconnais
Copy link
Member

Oups ... 😅

@ankushbhardwaj408
Copy link
Contributor Author

Hi @arthurzenika i will change it

@ankushbhardwaj408
Copy link
Contributor Author

ankushbhardwaj408 commented Oct 5, 2023

Hi @jeanphibaconnais i was having issue creating the pr because firstly i created the pr from my main branch and it was showing merge conflicts so i deleted the branch and now if i create another fork and submit a pr it would be my second pr so if you dont consider it a scam then i will change the name to ankushbhardwaj408.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants