Yang model modifications #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…CL yang models. [sonic-vlan.yang]: modify vlan table key from vlanid(int) to vlan_name(string). [yangModelTesting.py] Fix Test Code and JSON input.
li-pingmao
reviewed
Dec 6, 2019
| @@ -38,11 +38,11 @@ module sonic-vlan { | |||
|
|
|||
| list VLAN_INTERFACE_LIST { | |||
|
|
|||
| key "vlanid ip-prefix"; | |||
| key "vlan_name ip-prefix"; | |||
There was a problem hiding this comment.
What is the reason to remove vlanid from the vlan interface list, and replace key from vlanid to vlan_name?
li-pingmao
reviewed
Dec 6, 2019
| @@ -81,7 +81,13 @@ module sonic-vlan { | |||
|
|
|||
| list VLAN_LIST { | |||
|
|
|||
| key "vlanid"; | |||
| key "vlan_name"; | |||
There was a problem hiding this comment.
What is the reason to remove vlanid?
li-pingmao
approved these changes
Dec 8, 2019
zhenggen-xu
reviewed
Dec 9, 2019
| @@ -170,7 +170,7 @@ module sonic-acl { | |||
| choice icmp { | |||
|
|
|||
| case icmp4 { | |||
| when "boolean(IP_TYPE[.='ANY' or .='IP' or .='IPV4' or .='IPV4ANY' or .='ARP'])"; | |||
| when "boolean(IP_TYPE[.='ANY' or .='IP' or .='IPV4' or .='IPv4ANY' or .='IPV4ANY' or .='ARP'])"; | |||
There was a problem hiding this comment.
According to the aclorch.cpp backend code, all fields and values are converted to upper case. I think we should convert that too before yang model's validation.
praveen-li
commented
Dec 9, 2019
zhenggen-xu
approved these changes
Dec 11, 2019
zhenggen-xu
pushed a commit
that referenced
this pull request
Jan 10, 2020
* [sonic-head.yang]: Minor modification for enumeration of ip-type in ACL yang models. [sonic-vlan.yang]: modify vlan table key from vlanid(int) to vlan_name(string). [yangModelTesting.py] Fix Test Code and JSON input. * [sonic-acl.yang]: Present Enumeration similar to config DB. * [sonic-head.yang]: Minor update in enumeration
praveen-li
pushed a commit
to praveen-li/sonic-buildimage
that referenced
this pull request
Aug 12, 2020
* src/sonic-telemetry fa8d498...3bd7ca3 (4): > Update gnmi deps (zhenggen-xu#40) > [testdata] Update SFP keys to align with new standard (zhenggen-xu#39) > Fixed the parameters for subscribe APIs (zhenggen-xu#38) > Azure ro mode (zhenggen-xu#34) * src/sonic-mgmt-common 444aa9a...cc01ce4 (4): > Make gnmi dep version the same as in telemetry repo (zhenggen-xu#17) > Cleanup translib and cvl go test cases (zhenggen-xu#13) > Package update and enhancements/fixes in YGOT, and Request Binder (zhenggen-xu#12) > Translib phase I changes (zhenggen-xu#11) Note: sonic-telemetry submodule update is dependent upon sonic-mgmt-common submodule update, thus updating both in this patch
praveen-li
pushed a commit
to praveen-li/sonic-buildimage
that referenced
this pull request
Aug 9, 2022
Updated the hw-mgmt pointer to include some bugfixes related to power supply voltages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
- How I did it
Minor modification for enumeration of ip-type in ACL yang models.
modify vlan table key from vlanid(int) to vlan_name(string).
Fix Test Code and JSON input.
Note: I need to block Current PLY Tests because they do not pass with new YANG Models.
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)