-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
diskann for pr [WIP] #725
base: main
Are you sure you want to change the base?
diskann for pr [WIP] #725
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: xxxlzhxxx The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @xxxlzhxxx! It looks like this is your first PR to zilliztech/knowhere 🎉 |
@xxxlzhxxx 🔍 Important: PR Classification Needed! For efficient project management and a seamless review process, it's essential to classify your PR correctly. Here's how:
For any PR outside the kind/improvement category, ensure you link to the associated issue using the format: “issue: #”. Thanks for your efforts and contribution to the community!. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #725 +/- ##
=========================================
+ Coverage 0 71.78% +71.78%
=========================================
Files 0 69 +69
Lines 0 4905 +4905
=========================================
+ Hits 0 3521 +3521
- Misses 0 1384 +1384 |
This is the disk-ann iterator, it can be compile. The basic structure of the algorithm is correct. However, tests need to be completed.