Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outdated path since react 15.4.0 #87

Closed
dkwingsmt opened this issue Nov 16, 2016 · 4 comments
Closed

Outdated path since react 15.4.0 #87

dkwingsmt opened this issue Nov 16, 2016 · 4 comments

Comments

@dkwingsmt
Copy link

A few modules that this plugin depends on seems to have been moved to new places in the latest react (≥15.4.0), which triggers the following and alike errors:

Module not found: Error: Cannot resolve module 'react/lib/EventPluginHub' in /path/to/my/propject/node_modules/react-tap-event-plugin/src
Module not found: Error: Cannot resolve module 'react/lib/EventConstants' in /path/to/my/propject/node_modules/react-tap-event-plugin/src
... (and so on)

Btw, is this plugin still necessary? Facebook have closed #436 and #1170, but it seems they rejected them?

@s0meone
Copy link

s0meone commented Nov 16, 2016

I've just published a new version on npm (2.0.0) which fixes compatibility with React 15.4.

Yes, the plugin is still needed, see #81.

@s0meone s0meone closed this as completed Nov 16, 2016
@dkwingsmt
Copy link
Author

Thank you. And my apology for not checking closed issues before opening this one.

@dano-giftbit
Copy link

I'm not seeing 2.0.0 on npm ?

@s0meone
Copy link

s0meone commented Nov 16, 2016

$ npm view react-tap-event-plugin@latest version
2.0.0

The webpage on npmjs.org is cached probably. npm install will install the latest version.

spra85 added a commit to theonion/bulbs-elements that referenced this issue Nov 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants